[show] Added alias interface mode support for 'show interfaces counters ...' command #2468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs ...' command --- What I did This change fixed "show interfaces counters xxx" output nothing when naming mode is alias. Fixes sonic-net#2464 --- How I did it Convert the alias name into interface name for "show interfaces counters -u xxx", "show interfaces counters detailed xxx" and "show interfaces counters rif xxx" subcommands. --- How to verify it 1. Set interface naming mode to alias. 2. Logout/Login. 3. Verify "show interfaces counters -i Eth1". 4. Verify "show interfaces counters rif Eth1". 5. Verify "show interfaces counters detailed Eth1". 6. Set interface naming mode to default. 7. Repeat step 3~5. Signed-off-by: Julian Chang - TW <julianc@supermicro.com.tw>
|
@zjswhhh Would you please review my PR? Thanks! |
|
Is there any expert can help to review this PR? |
|
Actually the software test team of my company found many "alias naming mode" related problems. We don't know whether we should fix them one by one or just ask them to skip "alias naming mode" related testing.... |
Thanks for your time, @zjswhhh. Should I invite more reviewers to get this commit merged? Julian |
qiluo-msft
approved these changes
May 5, 2023
pdhruv-marvell
pushed a commit
to pdhruv-marvell/sonic-utilities
that referenced
this pull request
Aug 23, 2023
…rs ...' command (sonic-net#2468) Fixes sonic-net#2464 #### What I did This change fixed "show interfaces counters xxx" output nothing when naming mode is alias. #### How I did it Convert the alias name into interface name for "show interfaces counters -u xxx", "show interfaces counters detailed xxx" and "show interfaces counters rif xxx" subcommands. #### How to verify it 1. Set interface naming mode to alias. 2. Logout/Login. 3. Verify "show interfaces counters -i Eth1". 4. Verify "show interfaces counters rif Eth1". 5. Verify "show interfaces counters detailed Eth1". 6. Set interface naming mode to default. 7. Logout/Login 8. Repeat step 3~5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2464
Signed-off-by: Julian Chang - TW julianc@supermicro.com.tw
What I did
This change fixed "show interfaces counters xxx" output nothing when naming mode is alias.
How I did it
Convert the alias name into interface name for "show interfaces counters -u xxx", "show interfaces counters detailed xxx" and "show interfaces counters rif xxx" subcommands.
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)