[GCU] Fix JsonPointerFilter bug #2477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
approved these changes
Nov 4, 2022
ganglyu
approved these changes
Nov 4, 2022
isabelmsft
approved these changes
Nov 5, 2022
|
@wen587 Will you backport to 202205 branch? |
I have added the label for 202205. I will help if there is any conflict. |
7 tasks
yxieca
pushed a commit
that referenced
this pull request
Nov 10, 2022
What I did Fix a bug of JsonPointerFilter in GCU that will make the wrong selection of candidates. How I did it Add the patch addressing '|' in the prefix and suffix filter to avoid wrong selection. How to verify it Add UT.
preetham-singh
pushed a commit
to preetham-singh/sonic-utilities
that referenced
this pull request
Nov 21, 2022
What I did Fix a bug of JsonPointerFilter in GCU that will make the wrong selection of candidates. How I did it Add the patch addressing '|' in the prefix and suffix filter to avoid wrong selection. How to verify it Add UT.
mdanish-kh
pushed a commit
to mdanish-kh/sonic-utilities
that referenced
this pull request
Nov 23, 2022
What I did Fix a bug of JsonPointerFilter in GCU that will make the wrong selection of candidates. How I did it Add the patch addressing '|' in the prefix and suffix filter to avoid wrong selection. How to verify it Add UT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to #2273
Before the fix, the prefix pattern
Ethernet12|*would matchEthernet124|0andEthernet12|0.The suffix pattern
*|10would matchEthernet1|10andEthernet1|11110.What I did
Fix a bug of JsonPointerFilter in GCU that will make the wrong selection of candidates.
How I did it
Add the patch addressing '|' in the prefix and suffix filter to avoid wrong selection.
How to verify it
Add UT.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)