Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[route_check]: Ignore ASIC only SOC IPs #2548

Merged
merged 4 commits into from
Dec 13, 2022
Merged

[route_check]: Ignore ASIC only SOC IPs #2548

merged 4 commits into from
Dec 13, 2022

Commits on Dec 2, 2022

  1. [tests]: Improve route check test 

    - Split test into separate methods based on functionality being tested
- Parametrize main test method for better granularity when viewing results/running test cases
- Add config DB mocking support
- Move some setup/teardown code to fixtures for better consistency
- Extract test data to separate file

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
    @theasianpianist
    theasianpianist committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    96bc02a View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. [route_check]: Ignore ASIC only routes for SOC IPs 

    - Ignore routes for SOC IPs that are only present in the ASIC
- Add test case to cover ASIC only SOC IPs

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
    @theasianpianist
    theasianpianist committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    d2f038e View commit details
    Browse the repository at this point in the history

  2. Only skip active-active cables 

    Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
    @theasianpianist
    theasianpianist committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    de5c033 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2022

  1. add newline 

    Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
    @theasianpianist
    theasianpianist committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    9cbbce2 View commit details
    Browse the repository at this point in the history