Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202205][route_check]: Ignore ASIC only SOC IPs (cherry-picking #2548) #2552

Merged
merged 2 commits into from
Dec 13, 2022

Conversation

yxieca
Copy link
Contributor

@yxieca yxieca commented Dec 13, 2022

cherry-picking #2548

  • [tests]: Improve route check test
  • Split test into separate methods based on functionality being tested
  • Parametrize main test method for better granularity when viewing results/running test cases
  • Add config DB mocking support
  • Move some setup/teardown code to fixtures for better consistency
  • Extract test data to separate file
  • Ignore routes for SOC IPs that are only present in the ASIC
  • Add test case to cover ASIC only SOC IPs

Signed-off-by: Lawrence Lee lawlee@microsoft.com

…-net#2548)

* [tests]: Improve route check test

- Split test into separate methods based on functionality being tested
- Parametrize main test method for better granularity when viewing results/running test cases
- Add config DB mocking support
- Move some setup/teardown code to fixtures for better consistency
- Extract test data to separate file
- Ignore routes for SOC IPs that are only present in the ASIC
- Add test case to cover ASIC only SOC IPs

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
@yxieca
Copy link
Contributor Author

yxieca commented Dec 13, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
@yxieca yxieca merged commit 2c29fde into sonic-net:202205 Dec 13, 2022
@yxieca yxieca deleted the route branch December 13, 2022 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants