[show][mlnx] replace shell=True, replace xml #2700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: maipbui <maibui@microsoft.com>
qiluo-msft
reviewed
Feb 28, 2023
show/plugins/mlnx.py
Outdated
| @@ -46,9 +46,9 @@ def run_command(command, display_cmd=False, ignore_error=False, print_to_console | |||
| """Run bash command and print output to stdout | |||
| """ | |||
| if display_cmd == True: | |||
| click.echo(click.style("Running command: ", fg='cyan') + click.style(command, fg='green')) | |||
| click.echo(click.style("Running command: ", fg='cyan') + click.style(' '.join(command), fg='green')) | |||
Signed-off-by: maipbui <maibui@microsoft.com>
|
/azp run Azure.sonic-utilities |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@stepanblyschak @dprital Could you help review? |
qiluo-msft
previously approved these changes
Mar 7, 2023
|
@stepanblyschak @dprital could you help review? |
|
/azp run Azure.sonic-utilities |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
approved these changes
Apr 20, 2023
|
@keboliu could you help review? |
could you please also provide the test result of command "show platform mlnx sniffer"? |
I added in the PR description |
|
@keboliu could you check PR description and review PR? |
keboliu
approved these changes
May 10, 2023
pdhruv-marvell
pushed a commit
to pdhruv-marvell/sonic-utilities
that referenced
this pull request
Aug 23, 2023
Signed-off-by: maipbui <maibui@microsoft.com> #### What I did `subprocess()` - when using with `shell=True` is dangerous. Using subprocess function without a static string can lead to command injection. #### How I did it `subprocess()` - use `shell=False` instead, use list of strings Ref: [https://semgrep.dev/docs/cheat-sheets/python-command-injection/#mitigation](https://semgrep.dev/docs/cheat-sheets/python-command-injection/#mitigation) #### How to verify it Add UT Manual test ``` admin@***:~$ show platform mlnx issu ISSU is enabled admin@***:~$ show platform mlnx sniffer sdk sniffer is disabled ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: maipbui maibui@microsoft.com
What I did
subprocess()- when using withshell=Trueis dangerous. Using subprocess function without a static string can lead to command injection.How I did it
subprocess()- useshell=Falseinstead, use list of strings Ref: https://semgrep.dev/docs/cheat-sheets/python-command-injection/#mitigationHow to verify it
Add UT
Manual test
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)