Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[config]Support multi-asic Golden Config override (#2738)" #2820

Merged
merged 1 commit into from
May 3, 2023

Conversation

dprital
Copy link
Collaborator

@dprital dprital commented May 3, 2023

This reverts commit 8ae2424.

What I did

revert commit 8ae2424 from PR:
8ae2424 [config]Support multi-asic Golden Config override (#2738)

Because it lead to error when submodule update for sonic-utilities is set (see below)

2023-05-01T21:02:32.2330802Z Traceback (most recent call last):
2023-05-01T21:02:32.2331053Z   File "/usr/local/lib/python3.9/dist-packages/config/config_mgmt.py", line 60, in __init__
2023-05-01T21:02:32.2331232Z     self.configdb = ConfigDBConnector()
2023-05-01T21:02:32.2331478Z   File "/usr/lib/python3/dist-packages/swsscommon/swsscommon.py", line 2226, in __init__
2023-05-01T21:02:32.2331695Z     super(ConfigDBConnector, self).__init__(use_unix_socket_path = use_unix_socket_path, namespace = namespace)
2023-05-01T21:02:32.2331988Z   File "/usr/lib/python3/dist-packages/swsscommon/swsscommon.py", line 1855, in __init__
2023-05-01T21:02:32.2332152Z     for db_name in self.get_db_list():
2023-05-01T21:02:32.2332403Z   File "/usr/lib/python3/dist-packages/swsscommon/swsscommon.py", line 1791, in get_db_list
2023-05-01T21:02:32.2332579Z     return _swsscommon.SonicV2Connector_Native_get_db_list(self)
2023-05-01T21:02:32.2332866Z RuntimeError: Sonic database config file doesn't exist at /var/run/redis/sonic-db/database_config.json

How I did it

git revert commit 8ae2424

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@dprital dprital requested a review from liat-grozovik May 3, 2023 08:47
@liat-grozovik
Copy link
Collaborator

approved following an offline discuss with the author of the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants