Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Fix base OS compilation issue caused by incompatibility of urllib with requests. #2830

Merged
merged 1 commit into from
May 8, 2023
Merged

[build] Fix base OS compilation issue caused by incompatibility of urllib with requests. #2830

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,7 @@
},
install_requires=[
'click==7.0',
'urllib3<2',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need to limit urllib3 now.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @liushilongbuaa seems it's not fixed, I still see same issue in my local build, and it also failed the checker of PR sonic-net/sonic-swss#2763.

'click-log>=0.3.2',
'docker>=4.4.4',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker>=6.1.1

'docker-image-py>=0.1.10',
Expand Down