Revert "[warm-reboot] Use kexec_file_load instead of kexec_load when … #2833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…available (sonic-net#2608)" This reverts commit 93c7d43.
saiarcot895
approved these changes
May 10, 2023
|
@saiarcot895 does this mean the original issue that you fixed will reappear in 202012 after this revert? If yes, is it possible to provide a separate fix for 202012, since the cherry picked is not good. |
|
It's possible that the issue might reappear. I'll need to see why the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…available (#2608)"
This reverts commit 93c7d43.
What I did
Revert using kexec_file_load only 202012 branch only. Kexec_file_load is causing warm-reboot failure on kvm
admin@vlab-01:~$ sudo warm-reboot -vvvv
Wed 10 May 2023 12:20:58 AM UTC Saving counters folder before warmboot...
kexec_file_load failed: Key was rejected by service
Wed 10 May 2023 12:21:00 AM UTC warm-reboot failure (255) cleanup ...
Wed 10 May 2023 12:21:01 AM UTC Cancel warm-reboot: code (0)
admin@vlab-01:~$ sudo /sbin/kexec -a -l /host/image-202012-14937.266039-f379524f2/boot/vmlinuz-4.19.0-12-2-amd64 --initrd=/host/image-202012-14937.266039-f379524f2/boot/initrd.img-4.19.0-12-2-amd64 --append="BOOT_IMAGE=/image-202012-14937.266039-f379524f2/boot/vmlinuz-4.19.0-12-2-amd64 root=UUID=55f52500-e626-4865-ab33-54d72ca71c22 rw console=tty0 console=ttyS0,115200n8 quiet intel_idle.max_cstate=0 net.ifnames=0 biosdevname=0 loop=image-202012-14937.266039-f379524f2/fs.squashfs loopfstype=squashfs systemd.unified_cgroup_hierarchy=0 apparmor=1 security=apparmor varlog_size=4096 usbcore.autosuspend=-1 SONIC_BOOT_TYPE=warm"
kexec_file_load failed: Key was rejected by service
How I did it
Revert using "-a" flag
How to verify it
Run warm-reboot on kvm without '-a' flag
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)