Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[202211][db_migrator] Add migration of FLEX_COUNTER_DELAY_STATUS during 1911->2211 upgrade + fast-reboot. Add UT. #2838

Merged
merged 4 commits into from
Aug 17, 2023
Merged

[202211][db_migrator] Add migration of FLEX_COUNTER_DELAY_STATUS during 1911->2211 upgrade + fast-reboot. Add UT. #2838

merged 4 commits into from
Aug 17, 2023

Conversation

vadymhlushko-mlnx
Copy link
Contributor

@vadymhlushko-mlnx vadymhlushko-mlnx commented May 16, 2023 •
edited
Loading

What I did

Add migration of FLEX_COUNTER_DELAY_STATUS attribute of config_db FLEX_COUNTER_TABLE during the SONiC to SONiC upgrade + fast-reboot from older versions 201911 -> 202211.

This change is required for the fast-reboot procedure because without it the counters will be created during the init flow which will waste a lot of resources and cause data plane degradation of more than 30 seconds.

How I did it

Modify the db_migrator.py.

How to verify it

Add UT.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@keboliu keboliu requested a review from vaibhavhd May 31, 2023 08:20
@keboliu
Copy link
Collaborator

keboliu commented May 31, 2023

@vaibhavhd would you please help to review?

@vadymhlushko-mlnx vadymhlushko-mlnx force-pushed the 202211-flex-counter-delay-status-migration branch from 5f20cff to 48ce1ad Compare June 9, 2023 12:24
@vadymhlushko-mlnx vadymhlushko-mlnx changed the title [db_migrator] Add migration of FLEX_COUNTER_DELAY_STATUS during 1911->2211 upgrade + fast-reboot. Add UT. [202211][db_migrator] Add migration of FLEX_COUNTER_DELAY_STATUS during 1911->2211 upgrade + fast-reboot. Add UT. Jun 9, 2023
@vadymhlushko-mlnx vadymhlushko-mlnx mentioned this pull request Jun 9, 2023
Merged
vaibhavhd
vaibhavhd reviewed Jun 12, 2023
View reviewed changes
scripts/db_migrator.py Outdated Show resolved Hide resolved
@vadymhlushko-mlnx vadymhlushko-mlnx force-pushed the 202211-flex-counter-delay-status-migration branch from 48ce1ad to e3bbb92 Compare June 13, 2023 09:53
@vaibhavhd
Copy link
Contributor

Why is this change not needed on master?

@keboliu
Copy link
Collaborator

keboliu commented Jun 19, 2023

@vadymhlushko-mlnx please resolve the checker issue so we can proceed.

@vadymhlushko-mlnx
Copy link
Contributor Author

Why is this change not needed on master?

The PR's for other branches have already been created:

#2839
#2870
#2869

@vadymhlushko-mlnx vadymhlushko-mlnx force-pushed the 202211-flex-counter-delay-status-migration branch from 3eb54d4 to 8e423cc Compare June 19, 2023 12:23
@vadymhlushko-mlnx
[202211][db_migrator] Add migration of FLEX_COUNTER_DELAY_STATUS duri…
daf5460 
…ng 1911->2211 upgrade + fast-reboot. Add UT.

Signed-off-by: vadymhlushko-mlnx <vadymh@nvidia.com>
@vadymhlushko-mlnx vadymhlushko-mlnx force-pushed the 202211-flex-counter-delay-status-migration branch from 72d552c to daf5460 Compare July 3, 2023 08:34
@keboliu
Copy link
Collaborator

keboliu commented Jul 3, 2023

@StormLiangMS this PR is ready to be merged, would you please help?

vaibhavhd
vaibhavhd requested changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@vaibhavhd vaibhavhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version on 202211 and 202205 is same, this needs to be corrected. Blocking merge of this change until that.

@vadymhlushko-mlnx
[db_migrator] Set correct CURRENT_VERSION, extend UT
ed56449 
Signed-off-by: vadymhlushko-mlnx <vadymh@nvidia.com>
@vadymhlushko-mlnx vadymhlushko-mlnx force-pushed the 202211-flex-counter-delay-status-migration branch from 5099e74 to ed56449 Compare July 11, 2023 14:08
@vadymhlushko-mlnx
Copy link
Contributor Author

vadymhlushko-mlnx commented Jul 11, 2023 •
edited
Loading

The version on 202211 and 202205 is same, this needs to be corrected. Blocking merge of this change until that.

I've added a placeholder for the version_3_0_7 which is the same as for the 202205 branch. Could you please tell me if it is correct, if no could you please explain the logic behind defining proper DB migration version per branch?

@vadymhlushko-mlnx
Copy link
Contributor Author

The version on 202211 and 202205 is same, this needs to be corrected. Blocking merge of this change until that.

I've added a placeholder for the version_3_0_7 which is the same as for the 202205 branch. Could you please tell me if it is correct, if no could you please explain the logic behind defining proper DB migration version per branch?

@vaibhavhd kind reminder

@vadymhlushko-mlnx
[db_migrator] Change version to 4_0_3 for 202211 branch
673d484 
Signed-off-by: vadymhlushko-mlnx <vadymh@nvidia.com>
@vaibhavhd vaibhavhd merged commit d69432d into sonic-net:202211 Aug 17, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stepanblyschak stepanblyschak stepanblyschak approved these changes

@vaibhavhd vaibhavhd vaibhavhd approved these changes

@StormLiangMS StormLiangMS Awaiting requested review from StormLiangMS

@qiluo-msft qiluo-msft Awaiting requested review from qiluo-msft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vadymhlushko-mlnx @keboliu @vaibhavhd @stepanblyschak