Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[route_check][dualtor] Ignore vlan neighbor route miss #2888

Merged
merged 7 commits into from
Jul 13, 2023

Conversation

lolyu
Copy link
Contributor

@lolyu lolyu commented Jun 29, 2023

MSFT ADO: 24443895

What I did

As the subject.
This PR is to leave the vlan neighbor route checking to dualtor_neighbor_check.py script: #2840

Signed-off-by: Longxiang Lyu lolv@microsoft.com

How I did it

If any misses are found on dualtor, ignore those vlan neighbor misses.

How to verify it

UT and verify on testbed.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
@lolyu lolyu marked this pull request as ready for review June 29, 2023 08:03
@lolyu lolyu requested review from yxieca and prsunny June 29, 2023 08:09
Copy link
Contributor

@prsunny prsunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, @theasianpianist , please review as well

@prsunny
Copy link
Contributor

prsunny commented Jul 11, 2023

@lolyu , can you please provide a link to the new PR that handles dualtor routes

@lolyu
Copy link
Contributor Author

lolyu commented Jul 11, 2023

@lolyu , can you please provide a link to the new PR that handles dualtor routes

@prsunny this one: #2840

@lolyu
Copy link
Contributor Author

lolyu commented Jul 13, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lolyu lolyu merged commit fd49775 into sonic-net:master Jul 13, 2023
yxieca pushed a commit that referenced this pull request Jul 13, 2023
What I did
As the subject.
This PR is to leave the vlan neighbor route checking to dualtor_neighbor_check.py script: #2840

Signed-off-by: Longxiang Lyu lolv@microsoft.com

How I did it
If any misses are found on dualtor, ignore those vlan neighbor misses.

How to verify it
UT and verify on testbed.
StormLiangMS pushed a commit that referenced this pull request Jul 19, 2023
What I did
As the subject.
This PR is to leave the vlan neighbor route checking to dualtor_neighbor_check.py script: #2840

Signed-off-by: Longxiang Lyu lolv@microsoft.com

How I did it
If any misses are found on dualtor, ignore those vlan neighbor misses.

How to verify it
UT and verify on testbed.
rajkumar38 pushed a commit to rajkumar38/sonic-utilities that referenced this pull request Jul 25, 2023
What I did
As the subject.
This PR is to leave the vlan neighbor route checking to dualtor_neighbor_check.py script: sonic-net#2840

Signed-off-by: Longxiang Lyu lolv@microsoft.com

How I did it
If any misses are found on dualtor, ignore those vlan neighbor misses.

How to verify it
UT and verify on testbed.
pdhruv-marvell pushed a commit to pdhruv-marvell/sonic-utilities that referenced this pull request Aug 23, 2023
What I did
As the subject.
This PR is to leave the vlan neighbor route checking to dualtor_neighbor_check.py script: sonic-net#2840

Signed-off-by: Longxiang Lyu lolv@microsoft.com

How I did it
If any misses are found on dualtor, ignore those vlan neighbor misses.

How to verify it
UT and verify on testbed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants