Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dualtor][route_check] filter out soc_ipv6 #2899

Merged
merged 3 commits into from
Jul 12, 2023

Conversation

zjswhhh
Copy link
Contributor

@zjswhhh zjswhhh commented Jul 11, 2023

What I did

Skip soc_ipv6 when comparing appl_db and asic_db route entries on active-active dualtor. Because it's creating false alarms when tunnel route is added for soc ips. The route is meant to be programmed in asic only.

ADO#: 24499494

sign-off: Jing Zhang zhangjing@microsoft.com

How I did it

How to verify it

Run the updated script on active-active dualtor devices.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

prsunny
prsunny previously approved these changes Jul 11, 2023
@prsunny
Copy link
Contributor

prsunny commented Jul 11, 2023

Please add a test for the same

@lolyu lolyu merged commit 553a343 into sonic-net:master Jul 12, 2023
yxieca pushed a commit that referenced this pull request Jul 13, 2023
What I did
Skip soc_ipv6 when comparing appl_db and asic_db route entries on active-active dualtor. Because it's creating false alarms when tunnel route is added for soc ips. The route is meant to be programmed in asic only.

sign-off: Jing Zhang zhangjing@microsoft.com

How I did it
How to verify it
Run the updated script on active-active dualtor devices.
StormLiangMS pushed a commit that referenced this pull request Jul 19, 2023
What I did
Skip soc_ipv6 when comparing appl_db and asic_db route entries on active-active dualtor. Because it's creating false alarms when tunnel route is added for soc ips. The route is meant to be programmed in asic only.

sign-off: Jing Zhang zhangjing@microsoft.com

How I did it
How to verify it
Run the updated script on active-active dualtor devices.
rajkumar38 pushed a commit to rajkumar38/sonic-utilities that referenced this pull request Jul 25, 2023
What I did
Skip soc_ipv6 when comparing appl_db and asic_db route entries on active-active dualtor. Because it's creating false alarms when tunnel route is added for soc ips. The route is meant to be programmed in asic only.

sign-off: Jing Zhang zhangjing@microsoft.com

How I did it
How to verify it
Run the updated script on active-active dualtor devices.
@zjswhhh zjswhhh deleted the route_check_master branch July 26, 2023 18:37
pdhruv-marvell pushed a commit to pdhruv-marvell/sonic-utilities that referenced this pull request Aug 23, 2023
What I did
Skip soc_ipv6 when comparing appl_db and asic_db route entries on active-active dualtor. Because it's creating false alarms when tunnel route is added for soc ips. The route is meant to be programmed in asic only.

sign-off: Jing Zhang zhangjing@microsoft.com

How I did it
How to verify it
Run the updated script on active-active dualtor devices.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants