Revert "[GCU] Complete RDMA Platform Validator PR (#2857)" #2907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts PR #2857.
Purpose of revert: unblock E2E test test_add_rack.py, which was failing due to this RDMA Platform Validator PR. The RDMA Platform Validator was unexpectedly blocking updates to PFC_WD.
Additionally, spc3 asic support needs to be added (currently for Mellanox only spc1 is supported).
Changes to make before merging again:
-allow ADD operations for RDMA tables to ensure test_add_rack can pass (if ADD is not explicitly allowed, this platform validator will block changes to RDMA tables in test_add_rack).
-add support for spc3 asic
-ensure test_add_rack patch can be applied properly with this validator in place