Input check for timeout in generate_dump #2925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qiluo-msft can we get a reviewer for this fix please? |
ycoheNvidia
force-pushed
the
generate_dump_sanitization
branch
from
107b4b8
to
d3e7bce
Compare
qiluo-msft
approved these changes
Aug 2, 2023
pdhruv-marvell
pushed a commit
to pdhruv-marvell/sonic-utilities
that referenced
this pull request
Aug 23, 2023
#### What I did Added input check for argument "-t" in generate_dump script #### How I did it Made sure only integer values can be received for this argument #### How to verify it Call generate_dump -t with non-integer values
maipbui
pushed a commit
to maipbui/sonic-utilities
that referenced
this pull request
Jul 18, 2024
#### What I did Added input check for argument "-t" in generate_dump script #### How I did it Made sure only integer values can be received for this argument #### How to verify it Call generate_dump -t with non-integer values
maipbui
pushed a commit
to maipbui/sonic-utilities
that referenced
this pull request
Jul 18, 2024
#### What I did Added input check for argument "-t" in generate_dump script #### How I did it Made sure only integer values can be received for this argument #### How to verify it Call generate_dump -t with non-integer values
StormLiangMS
pushed a commit
that referenced
this pull request
Jul 18, 2024
#### What I did Added input check for argument "-t" in generate_dump script #### How I did it Made sure only integer values can be received for this argument #### How to verify it Call generate_dump -t with non-integer values Co-authored-by: ycoheNvidia <99744138+ycoheNvidia@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added input check for argument "-t" in generate_dump script
How I did it
Made sure only integer values can be received for this argument
How to verify it
Call generate_dump -t with non-integer values
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)