[202311] Support reading/writing module EEPROM data by page and offset (#3008) #3073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Junchao-Mellanox
changed the title
Junchao-Mellanox
changed the title
|
/azpw run Azure.sonic-utilities |
|
/AzurePipelines run Azure.sonic-utilities |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-utilities |
|
/AzurePipelines run Azure.sonic-utilities |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@prgeor please approve the PR as well |
…net#3008) * Support reading/writing module EEPROM data by page and offset * Fix unit test issue * Fix unit test issue * Fix review comment * Update command ref * Fix format * Update main.py * Fix review comments * Fix review comment * Remove un-intended change * Update Command-Reference.md * Update Command-Reference.md * Fix review comments * Fix review comments * User click.IntRange to avoid duplicate validation * Fix review comments * Update sfputil_test.py
Junchao-Mellanox
force-pushed
the
202311-rw-eeprom
branch
from
641c6ad
to
30e51af
Compare
|
@prgeor can you approve the backport one as well? |
keboliu
approved these changes
Jan 2, 2024
prgeor
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR to 202311: #3008
What I did
Add two CLIs:
Allow user to read/write EEPROM by page and offset
How I did it
See design:
sonic-net/SONiC#1475
How to verify it
Unit test
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)