-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master][chassis][show-runningconfig] Fix the show runningconfiguration all issue on the Supervisor #3194
[master][chassis][show-runningconfig] Fix the show runningconfiguration all issue on the Supervisor #3194
Conversation
…ssue on the Supervisor Signed-off-by: mlok <marty.lok@nokia.com>
@rlhui @judyjoseph Please review this PR for master branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Please wait for other review's approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@gechiang This PR has a bug fix and need to be backported to 202205 chassis |
@wen587 , |
MSFT ADO: 28384064 |
What I did
bgp is not supported on Supervisor card, "show runningconfiguration all" fails on the Supervisor since the bgp services is disable. Add code to check if bgp state in the FEATURE table is able before it tries to get the BGP configuration to avoid the error. Fix issue sonic-net/sonic-buildimage#18276
How I did it
Since BGP feature state is disabled in the FEATURE table on Supervisor card, add method is_bgp_feature_state_enabled() to the bgp_util.py check the BGP feature state. Modify the "show runningconfiguration all" to call the is_bgp_feature_state_enabled(), then call the run_ngp_show _command to get the bgp configuration.
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)