Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to use IPv6 linklocal address as snmp agent address #3215

Merged
merged 11 commits into from
Aug 5, 2024
Merged

Fix to use IPv6 linklocal address as snmp agent address #3215

merged 11 commits into from
Aug 5, 2024

Conversation

SuvarnaMeenakshi
Copy link
Contributor

@SuvarnaMeenakshi SuvarnaMeenakshi commented Mar 13, 2024 •
edited
Loading

What I did

If link local IPv6 address is added as SNMP agent address, it will fail.
This PR requires changes in snmpd.conf.j2 template here sonic-net/sonic-buildimage#18350

How I did it

Append scope id to ipv6 link local IP address.

How to verify it

Able to configure link local ipv6 address as snmp agent address

sudo config snmpagentaddress add fe80::2a99:3aff:fe17:1c08%eth0


 sonic-db-cli CONFIG_DB keys "*SNMP*AGENT*"
SNMP_AGENT_ADDRESS_CONFIG|FC00:1::32|161|
SNMP_AGENT_ADDRESS_CONFIG|2a01::ae|161|
SNMP_AGENT_ADDRESS_CONFIG|10.1.0.32|161|
SNMP_AGENT_ADDRESS_CONFIG|10..0.13|161|
SNMP_AGENT_ADDRESS_CONFIG|fe80::2a99:3aff:fe17:1c08%eth0||
..
SNMP_AGENT_ADDRESS_CONFIG|fe80::3a38:a6ff:fe98:e960%eth0||  ---- Newly added agent IP along with zone id
SNMP_AGENT_ADDRESS_CONFIG|FC00:1::32|161|
SNMP_COMMUNITY|<>
...

docker exec -it snmp cat /etc/snmp/snmpd.conf | grep agentAddress
agentAddress udp:[10.1.0.32]:161
agentAddress udp:[10.0.0.13]:161
agentAddress udp6:[2a01::a]:161
agentAddress udp6:[FC00:1::32]:161
agentAddress udp6:[fe80::2a99:3aff:fe17:1c08%eth0]

docker exec -it snmp snmpwalk -v2c -c <comm> fe80::2a99:3aff:fe17:1c08%eth0 1.3.6.1.2.1.1.1.0
iso.3.6.1.2.1.1.1.0 = STRING: "SONiC Software Version: SONiC.<> - HwSku: Arista-<> - Distribution: Debian 11.10 - Kernel: 5.10.0-23-2-amd64"

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@SuvarnaMeenakshi
Fix to use IPv6 linklocal address as snmp agent address
02cc0fa 
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
This was referenced Mar 13, 2024
Closed
Open
@keboliu
Copy link
Collaborator

keboliu commented Mar 18, 2024

@SuvarnaMeenakshi would you please address the covrage issue?

@keboliu keboliu requested a review from qiluo-msft April 15, 2024 06:28
@dgsudharsan
Copy link
Collaborator

@SuvarnaMeenakshi Can you please address the coverage issue?

@bingwang-ms
Copy link
Contributor

@SuvarnaMeenakshi Please fix the coverage issue. Appreciate if you can share an ETA.

@keboliu
Copy link
Collaborator

keboliu commented May 13, 2024

@SuvarnaMeenakshi would you please fix the coverage issue?

@SuvarnaMeenakshi
Add unit-test
bbde4a4 
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
@SuvarnaMeenakshi
fix ut
fefb642 
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
@SuvarnaMeenakshi
Fix flake8
4b52448 
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
@SuvarnaMeenakshi
fix flake8
33bc656 
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
@keboliu
Copy link
Collaborator

keboliu commented May 23, 2024

@qiluo-msft would you please review?

@SuvarnaMeenakshi
Modify cli to add agent ip along with zone id for link
f56f61a 
local ip

Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
@SuvarnaMeenakshi
Copy link
Contributor Author

@qiluo-msft @keboliu
Can we set the expectation that while adding snmpAgent address using CLI, the zone id will be added by the use or in the configuration.
For example: sudo config snmpagentaddress add fe80::3a38:a6ff:fe98:e960%eth0

@SuvarnaMeenakshi SuvarnaMeenakshi mentioned this pull request May 30, 2024
Merged
8 tasks
@SuvarnaMeenakshi
Fix to add zone id in config command
6d7f532 
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
qiluo-msft
qiluo-msft reviewed May 31, 2024
View reviewed changes
config/main.py Outdated Show resolved Hide resolved
@SuvarnaMeenakshi
Update as per review comment
68fc8ea 
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
@keboliu
Copy link
Collaborator

keboliu commented Jun 7, 2024

@SuvarnaMeenakshi seems there is a unit test issue, would you please check?

@SuvarnaMeenakshi SuvarnaMeenakshi mentioned this pull request Jun 14, 2024
Open
qiluo-msft
qiluo-msft previously approved these changes Jul 22, 2024
View reviewed changes
@SuvarnaMeenakshi
Fix unit test
f8db6d4 
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
@SuvarnaMeenakshi
Fix check to match interface ip and agent ip being added
709b9d6 
using cli

Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
qiluo-msft
qiluo-msft previously approved these changes Aug 2, 2024
View reviewed changes
@SuvarnaMeenakshi
netifaces provides ipadress along with zoneid
214b222 
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
@SuvarnaMeenakshi SuvarnaMeenakshi merged commit 018eb73 into sonic-net:master Aug 5, 2024
7 checks passed
wangxin pushed a commit to sonic-net/sonic-mgmt that referenced this pull request Aug 12, 2024
@SuvarnaMeenakshi
Modify snmp link local test to use config cli (#13070)
9b3d5d8 
Modify snmp_link_local_test to test after configuring link local snmp agent address using config snmpagentaddress cli.
Pre requisite: sonic-net/sonic-utilities#3215

Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
mssonicbld pushed a commit to mssonicbld/sonic-utilities that referenced this pull request Aug 12, 2024
@SuvarnaMeenakshi @mssonicbld
Fix to use IPv6 linklocal address as snmp agent address (sonic-net#3215)
1261930 
What I did
If link local IPv6 address is added as SNMP agent address, it will fail.
This PR requires changes in snmpd.conf.j2 template here sonic-net/sonic-buildimage#18350

How I did it
Append scope id to ipv6 link local IP address.

How to verify it
Able to configure link local ipv6 address as snmp agent address
sudo config snmpagentaddress add fe80::a%eth0
@mssonicbld mssonicbld mentioned this pull request Aug 12, 2024
Merged
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #3487

mssonicbld pushed a commit that referenced this pull request Aug 12, 2024
@SuvarnaMeenakshi @mssonicbld
Fix to use IPv6 linklocal address as snmp agent address (#3215)
8cf1c66 
What I did
If link local IPv6 address is added as SNMP agent address, it will fail.
This PR requires changes in snmpd.conf.j2 template here sonic-net/sonic-buildimage#18350

How I did it
Append scope id to ipv6 link local IP address.

How to verify it
Able to configure link local ipv6 address as snmp agent address
sudo config snmpagentaddress add fe80::a%eth0
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Sep 3, 2024
@SuvarnaMeenakshi @mssonicbld
Modify snmp link local test to use config cli (sonic-net#13070)
9bf586d 
Modify snmp_link_local_test to test after configuring link local snmp agent address using config snmpagentaddress cli.
Pre requisite: sonic-net/sonic-utilities#3215

Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
@mssonicbld mssonicbld mentioned this pull request Sep 3, 2024
Merged
8 tasks
mssonicbld pushed a commit to sonic-net/sonic-mgmt that referenced this pull request Sep 3, 2024
@SuvarnaMeenakshi @mssonicbld
Modify snmp link local test to use config cli (#13070)
b65756f 
Modify snmp_link_local_test to test after configuring link local snmp agent address using config snmpagentaddress cli.
Pre requisite: sonic-net/sonic-utilities#3215

Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Sep 6, 2024
@SuvarnaMeenakshi @mssonicbld
Modify snmp link local test to use config cli (sonic-net#13070)
cf85a25 
Modify snmp_link_local_test to test after configuring link local snmp agent address using config snmpagentaddress cli.
Pre requisite: sonic-net/sonic-utilities#3215

Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
@mssonicbld mssonicbld mentioned this pull request Sep 6, 2024
Merged
8 tasks
mssonicbld pushed a commit to sonic-net/sonic-mgmt that referenced this pull request Sep 6, 2024
@SuvarnaMeenakshi @mssonicbld
Modify snmp link local test to use config cli (#13070)
20773ec 
Modify snmp_link_local_test to test after configuring link local snmp agent address using config snmpagentaddress cli.
Pre requisite: sonic-net/sonic-utilities#3215

Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiluo-msft qiluo-msft qiluo-msft approved these changes

Assignees
No one assigned
Labels
Approved for 202405 Branch Included in 202405 Branch Request for 202405 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SuvarnaMeenakshi @keboliu @dgsudharsan @bingwang-ms @mssonicbld @qiluo-msft