Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Db migrator & Vlan Changes #3243

Closed
wants to merge 0 commits into from

Conversation

sabakram
Copy link
Contributor

What I did

This PR is Fixture for #3108. We have removed dbmigrator changes to avoid backward compatibility issues.

How I did it

Removed Dbmigrator changes from dbmigrator.py and dbmigrator_test.py

How to verify it

Dbmigrator changes has been removed

@sabakram sabakram changed the title Removed Db migrator changes as per latest suggestions Fix for Db migrator & Vlan Changes Mar 26, 2024
@sabakram
Copy link
Contributor Author

@wen587 @qiluo-msft
Hi, we have removed DB migrator changes and catered to backward compatibility concerns in vlan.py. Can you please review this PR and suggest any other changes required to avoid backward compatibility issues. This is in reference to PR #3108 .

config/vlan.py Outdated
if "mode" not in port_data:
ctx.fail("{} is in routed mode!\nUse switchport mode command to change port mode".format(port))
else:
if "mode" in port_data:
existing_mode = port_data["mode"]

if existing_mode == "routed":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If "mode" not in port_data, the existing_mode should be undefined.
Why is it not caught by build or test?

@wen587
Copy link
Contributor

wen587 commented Mar 27, 2024

Hi @sabakram , I tried submodule without your PR. sonic-net/sonic-buildimage#18480 It pass sonic-mgmt test. I suggest to revert it first to unblock submodule update.
You can have more time to improve the unit test to cover more use cases, especially the one used in test_vlan_interface.py

@sabakram
Copy link
Contributor Author

Hi @wen587 , ok we can revert this PR to avoid blocking for submodule head. but this revert is already done once earler.
and this new PR was created totally after suggestions.
This case is being pending since long and every time all changes are done as per suggestions from start but still we have open PR for same case which is also causing blocking issues and compatibility issues. It would be great help if you reviewed PR and provide suggested changes again at once so we can re do all code to resolve this case.

@wen587
Copy link
Contributor

wen587 commented Mar 28, 2024

Hi @sabakram , sure I'm willing to help with the review

@sabakram sabakram closed this Mar 28, 2024
@sabakram sabakram force-pushed the Switchport_Dbmigrator_Fix branch from e6f1b69 to bdc5720 Compare March 28, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants