Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config]Support single file reload for multiasic #3349

Merged
merged 8 commits into from
Jun 18, 2024

Conversation

wen587
Copy link
Contributor

@wen587 wen587 commented May 31, 2024

ADO: 27595279

What I did

Extend config reload to support single file reloading for multi-asic

How I did it

Add the single file reload support for mutli-asic

How to verify it

Unit test and manual test on multi-asic DUT

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@wen587 wen587 marked this pull request as ready for review June 6, 2024 06:51
config/main.py Outdated Show resolved Hide resolved
config/main.py Outdated Show resolved Hide resolved
xincunli-sonic
xincunli-sonic previously approved these changes Jun 11, 2024
Copy link
Contributor

@xincunli-sonic xincunli-sonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

config/main.py Show resolved Hide resolved
config/main.py Outdated Show resolved Hide resolved
config/main.py Outdated Show resolved Hide resolved
config/main.py Outdated Show resolved Hide resolved
config/main.py Outdated Show resolved Hide resolved
@wen587 wen587 changed the title [cnfig]Support single file reload for multiasic [config]Support single file reload for multiasic Jun 11, 2024
config/main.py Outdated Show resolved Hide resolved
return client, config_db


def migrate_db_to_lastest(namespace=DEFAULT_NAMESPACE):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

migrate_db_to_lastest

@vaibhavhd Could you help review?

clicommon.run_command(command, display_cmd=True)


def multiasic_write_to_db(filename, load_sysinfo):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multiasic_write_to_db

@rlhui @abdosi @judyjoseph Could you help review?

config/main.py Outdated Show resolved Hide resolved
@judyjoseph
Copy link
Contributor

looks ok to me. Btw are you validating the switch booting up with a single config file ? or this is just "config reload" command changes. I have this question, because there could be startup scripts where we explicitly check for the presence of config_db.json

@wen587
Copy link
Contributor Author

wen587 commented Jun 14, 2024

looks ok to me. Btw are you validating the switch booting up with a single config file ? or this is just "config reload" command changes. I have this question, because there could be startup scripts where we explicitly check for the presence of config_db.json

This is just config reload command and it will not impact booting up.

@wen587 wen587 merged commit 8f715ac into sonic-net:master Jun 18, 2024
7 checks passed
@qiluo-msft
Copy link
Contributor

@gechiang Could you help backport?

wen587 added a commit to wen587/sonic-utilities that referenced this pull request Aug 8, 2024
ADO: 27595279

What I did
Extend config reload to support single file reloading for multi-asic

How I did it
Add the single file reload support for mutli-asic

How to verify it
Unit test and manual test on multi-asic DUT
@wen587
Copy link
Contributor Author

wen587 commented Aug 8, 2024

#3481

bingwang-ms pushed a commit that referenced this pull request Aug 8, 2024
ADO: 27595279

What I did
Extend config reload to support single file reloading for multi-asic

How I did it
Add the single file reload support for mutli-asic

How to verify it
Unit test and manual test on multi-asic DUT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants