-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[config]Support single file reload for multiasic #3349
Conversation
…lities into refactor_reload
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
return client, config_db | ||
|
||
|
||
def migrate_db_to_lastest(namespace=DEFAULT_NAMESPACE): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vaibhavhd Could you help review?
clicommon.run_command(command, display_cmd=True) | ||
|
||
|
||
def multiasic_write_to_db(filename, load_sysinfo): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rlhui @abdosi @judyjoseph Could you help review?
looks ok to me. Btw are you validating the switch booting up with a single config file ? or this is just "config reload" command changes. I have this question, because there could be startup scripts where we explicitly check for the presence of config_db.json |
This is just config reload command and it will not impact booting up. |
@gechiang Could you help backport? |
ADO: 27595279 What I did Extend config reload to support single file reloading for multi-asic How I did it Add the single file reload support for mutli-asic How to verify it Unit test and manual test on multi-asic DUT
ADO: 27595279
What I did
Extend config reload to support single file reloading for multi-asic
How I did it
Add the single file reload support for mutli-asic
How to verify it
Unit test and manual test on multi-asic DUT
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)