Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PVST Feature commit #3567

Merged
merged 106 commits into from
Nov 14, 2024
Merged

PVST Feature commit #3567

merged 106 commits into from
Nov 14, 2024

Conversation

divyachandralekha
Copy link
Contributor

What I did
Added config/show/debug/clear handling for STP
Modified other utilities script to include STP

How I did it
How to verify it

@divyachandralekha divyachandralekha changed the title PVST Feature Enable PVST Feature commit Oct 4, 2024
@divyachandralekha
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

@ridahanif96
Copy link
Contributor

/azpw run Azure.sonic-utilities

@divyachandralekha
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ridahanif96
Copy link
Contributor

/azpw run

@divyachandralekha
Copy link
Contributor Author

@xincunli-sonic @hdwhdw
I have addressed all review comments. Please approve the changes.

@divyachandralekha
Copy link
Contributor Author

@qiluo-msft . Please help to merge the changes.

hdwhdw
hdwhdw reviewed Nov 12, 2024
View reviewed changes
tests/stp_test.py Outdated Show resolved Hide resolved
tests/stp_test.py Show resolved Hide resolved
@adyeung adyeung mentioned this pull request Nov 12, 2024
Merged
@divyachandralekha
Copy link
Contributor Author

@qiluo-msft, could you please help in merging the changes? As for the comments related to JSON comparison for the show output, we will address them as part of the MSTP code merge.

@yuezhoujk yuezhoujk requested review from yuezhoujk and removed request for yuezhoujk November 14, 2024 05:58
@yuezhoujk yuezhoujk merged commit a8f7bde into sonic-net:master Nov 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xincunli-sonic xincunli-sonic xincunli-sonic left review comments

@qiluo-msft qiluo-msft qiluo-msft left review comments

@hdwhdw hdwhdw hdwhdw left review comments

@wajahatrazi wajahatrazi wajahatrazi approved these changes

@yuezhoujk yuezhoujk yuezhoujk approved these changes

@adyeung adyeung adyeung approved these changes

@bendrapubalareddy bendrapubalareddy bendrapubalareddy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@divyachandralekha @mssonicbld @ridahanif96 @adyeung @bendrapubalareddy @xincunli-sonic @hdwhdw @qiluo-msft @yuezhoujk @wajahatrazi