Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202405] Fix Backtrace in route-check during config reload/minigraph. #3681

Open
wants to merge 3 commits into
base: 202405
Choose a base branch
from

Conversation

abdosi
Copy link
Contributor

@abdosi abdosi commented Dec 16, 2024

What I did:

Fix below BT:

Program 'routeCheck'
  status                       Status ok
  monitoring status            Monitored
  monitoring mode              active
  on reboot                    start
  last exit value              1
  last output                  Exiting: failed to connect to any daemons.
                               Traceback (most recent call last):
                                 File "/usr/local/bin/route_check.py", line 878, in <module>
                                   sys.exit(main()[0])
                                            ^^^^^^
                                 File "/usr/local/bin/route_check.py", line 864, in main
                                   ret, res= check_routes(namespace)
                                             ^^^^^^^^^^^^^^^^^^^^^^^
                                 File "/usr/local/bin/route_check.py", line 794, in check_routes
                                   if is_bgp_suppress_fib_pending_enabled(namespace):
                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                 File "/usr/local/bin/route_check.py", line 337, in is_bgp_suppress_fib_pending_enabled
                                   output = subprocess.check_output(show_run_cmd, text=True)
                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                 File "/usr/lib/python3.11/subprocess.py", line 466, in ch
  data collected               Mon, 16 Dec 2024 02:26:37

How I did:
Make API is_bgp_suppress_fib_pending_enabled always return False as on 202405 image this feature is not supported.

1. For config reload/minigraph stop and re-enable routeCheck because
with large route scale of 70K+ routes this can log monit error
transiently which can also fail in sonic-mgmt.
2. Also make API is_bgp_suppress_enable as this can return backtrace in
config reload/minigraph as bgp containe rmight not be up and running.

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Config reload/minigraph as bgp containe rmight not be up and running.

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
@abdosi abdosi requested a review from yejianquan December 16, 2024 09:43
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@abdosi
Copy link
Contributor Author

abdosi commented Dec 16, 2024

@xumia @liushilongbuaa : can you check this build error ?

@abdosi
Copy link
Contributor Author

abdosi commented Dec 16, 2024

@liushilongbuaa : is the build error of not able to download swss-common package is expected ?

@abdosi
Copy link
Contributor Author

abdosi commented Dec 16, 2024

@bingwang-ms @StormLiangMS : please help signoff this for 202405.

@bingwang-ms
Copy link
Contributor

@abdosi PR checker is failing. I just retriggered it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants