[warm-reboot] initialize warm reboot state table before warm rebooting #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that when the new image boots up, the component state won't be 'reconciled'. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
jipanyang
reviewed
Mar 28, 2019
jipanyang
approved these changes
Mar 28, 2019
qiluo-msft
reviewed
Mar 28, 2019
| @@ -106,6 +106,18 @@ function clear_warm_boot() | |||
| fi | |||
| } | |||
|
|
|||
| function init_warm_reboot_states() | |||
There was a problem hiding this comment.
init_warm_reboot_states [](start = 9, length = 23)
You could move code into backup_database(). And consider to adapt the optimization there. #Closed
There was a problem hiding this comment.
That would interfere the warm reboot. Syncd warmshutdown uses this table to coordinate operations. Some module might (not today, but maybe in the future) want to leave information to be handled after warm reboot is done. So it would be best to clear the table before any real warm reboot operation started.
There was a problem hiding this comment.
Incorporated the optimization. Thanks!
qiluo-msft
approved these changes
Mar 30, 2019
yxieca
added a commit
that referenced
this pull request
Mar 30, 2019
#492) * [warm-reboot] initialize warm reboot state table before warm rebooting Make sure that when the new image boots up, the component state won't be 'reconciled'. Signed-off-by: Ying Xie <ying.xie@microsoft.com> * fix typo * optimize state deletion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Make sure that when the new image boots up, the component state won't
be 'reconciled'.
Signed-off-by: Ying Xie ying.xie@microsoft.com
- How to verify it
continuous warm reboot.
admin@str-7260cx3-acs-1:~$ show warm_restart state ; uptime
name restore_count state
syncd 83
vlanmgrd 83
neighsyncd 83 reconciled
portsyncd 83
teammgrd 83
bgp 83 reconciled
warm-shutdown 0 pre-shutdown-succeeded
orchagent 83 reconciled
teamsyncd 83
16:13:00 up 6 min, 1 user, load average: 2.81, 1.54, 0.76
admin@str-7260cx3-acs-1:~$ show warm_restart state ; uptime
name restore_count state
syncd 83
vlanmgrd 83
neighsyncd 83
portsyncd 83
teammgrd 83
bgp 83
warm-shutdown 0
orchagent 83
teamsyncd 83
16:13:08 up 6 min, 1 user, load average: 2.61, 1.53, 0.77