-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[config] Add 'feature' subcommand #746
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
suggested changes
Nov 20, 2019
changing argument name to state and adding click.choice removed keyname
jleveque
suggested changes
Nov 21, 2019
jleveque
suggested changes
Nov 21, 2019
jleveque
changed the title
add config command feature_status
[config] Add 'feature' subcommand
Nov 21, 2019
Co-Authored-By: Joe LeVeque <jleveque@users.noreply.github.com>
removed context
…lities into addconfigfeature
hui-ma
reviewed
Nov 22, 2019
jleveque
suggested changes
Nov 23, 2019
removing check for state and name empty
jleveque
suggested changes
Nov 23, 2019
jleveque
suggested changes
Nov 26, 2019
jleveque
suggested changes
Nov 27, 2019
jleveque
approved these changes
Nov 27, 2019
Retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
added command to configure feature status
- How I did it
By adding in main.py
- How to verify it
config feature_status name value
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)