Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fast/warm reboot] ignore errors after shutting down critical service(s) #761

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

yxieca
Copy link
Contributor

@yxieca yxieca commented Dec 9, 2019

- What I did

Once any critical service is shutdown (radv/swss/syncd), we have to
commit to the reboot. Failing in the middle will leave the system in
bad state.

Signed-off-by: Ying Xie ying.xie@microsoft.com

Once any critical service is shutdown (radv/swss/syncd), we have to
commit to the reboot. Failing in the middle will leave the system in
bad state.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@yxieca
Copy link
Contributor Author

yxieca commented Dec 9, 2019

Encounter issue in continuous warm-reboot test. I believe the problem came from stopping docker service.

Mon Dec 9 05:59:14 UTC 2019 Stopped teamd ...
Mon Dec 9 05:59:14 UTC 2019 Stopping syncd ...
Mon Dec 9 06:02:14 UTC 2019 Stopped syncd ...
Mon Dec 9 06:02:14 UTC 2019 Stopping all remaining containers ...
Mon Dec 9 06:02:17 UTC 2019 Stopped all remaining containers ...
Job for docker.service canceled.
Mon Dec 9 06:02:17 UTC 2019 warm-reboot failure (1) cleanup ...
Traceback (most recent call last):
File "/usr/bin/config", line 9, in
load_entry_point('sonic-utilities==1.2', 'console_scripts', 'config')()
File "/usr/lib/python2.7/dist-packages/click/core.py", line 722, in call
return self.main(*args, **kwargs)

@yxieca yxieca requested a review from lguohan December 9, 2019 21:29
@yxieca yxieca merged commit 41f5961 into sonic-net:master Dec 10, 2019
@yxieca yxieca deleted the reboot branch December 10, 2019 04:48
yxieca added a commit that referenced this pull request Dec 11, 2019
…(s) (#761)

Once any critical service is shutdown (radv/swss/syncd), we have to
commit to the reboot. Failing in the middle will leave the system in
bad state.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
abdosi pushed a commit that referenced this pull request Jan 3, 2020
…(s) (#761)

Once any critical service is shutdown (radv/swss/syncd), we have to
commit to the reboot. Failing in the middle will leave the system in
bad state.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants