Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly specify command with underscores #846

Merged
merged 1 commit into from
Mar 22, 2020

Conversation

lguohan
Copy link
Contributor

@lguohan lguohan commented Mar 21, 2020

Starting click 7.0. The default behavior of a command with under
scores will be replace with dashes.

this is to address the above default behavior change, so that
the command remains the same.

more details can be found:

pallets/click#1123

- What I did

- How I did it

- How to verify it
tested for under current click and click 7.0

under buster

admin@vlab-01:/$ sudo config load
load              load_mgmt_config  load_minigraph    
admin@vlab-01:/$ sudo config load

- Previous command output (if the output of a command-line utility has changed)

- New command output (if the output of a command-line utility has changed)

Starting click 7.0. The default behavior of a command with under
scores will be replace with dashes.

this is to address the above default behavior change, so that
the command remains the same.

more details can be found:

pallets/click#1123
@lguohan lguohan requested a review from jleveque March 21, 2020 23:51
Copy link
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think moving forward we should create all new subcommands using hyphens, and eventually transition these to use hyphens also. We can transition by using aliases for a few versions.

@jleveque
Copy link
Contributor

@lguohan: I'm not sure if you want to handle other CLI utilities in this PR also, but I know for a fact sonic_installer has many subcommands which contain underscores.

@lguohan lguohan merged commit 780673c into sonic-net:master Mar 22, 2020
@lguohan lguohan deleted the click7 branch March 22, 2020 01:18
@lguohan
Copy link
Contributor Author

lguohan commented Mar 22, 2020

@jleveque , i agree with you.

abdosi pushed a commit that referenced this pull request Mar 24, 2020
Starting click 7.0. The default behavior of a command with under
scores will be replace with dashes.

this is to address the above default behavior change, so that
the command remains the same.

more details can be found:

pallets/click#1123
abdosi pushed a commit to abdosi/sonic-utilities that referenced this pull request Aug 4, 2020
Starting click 7.0. The default behavior of a command with under
scores will be replace with dashes.

this is to address the above default behavior change, so that
the command remains the same.

more details can be found:

pallets/click#1123
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
[fwutil]: Use overlay driver when mounting next image filesystem (sonic-net#825)
Fix for adding L3 interface to Vlan group (sonic-net#826)Fix for adding L3 interface to Vlan group (sonic-net#826)
[db_migrator]Do DB migration for buffer pool size change on Mellanox platform (sonic-net#833)
explicitly specify command with underscores (sonic-net#846)
[intfutil] set speed to 0 when interface speed is not available (sonic-net#839)
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
6cfb3ecb0248768da0a91e5f7fb4477c5da7eb4e (HEAD -> 201911, origin/201911) [build]: allow to use extra inc/lib location to build the package (sonic-net#595)
40d34872d3b7f354adac67f084eebf6ee467f779 Merge pull request sonic-net#846 from xumia/azp-201911
76ac50f147a7d820b19d8d7628a67f2fe4f5159b Disable the build test
6c9cf655b8b5b152cab1d578e05eddf8238b81b0 Fix branch reference error
ca8d81d37a9b0294098f161b036d330d9ff461e0 [ci]: download artifacts from master branch (sonic-net#768)
0cbf4d55c67a9f8f52715f95536f3588acf06c4a [ci]: use sonicbld pool (sonic-net#766)
b6f1265ee9bd86f8a5e909a6f1e9b2384497c906 [ci]: add build for arm64 and armhf (sonic-net#757)
9ec0a7da64d479b124815edc5b505fb88b2532a0 CI: add azure pipeline CI/CD (sonic-net#754)
1436dbe02cd3c56f796c6b3398d4075cd05d97e0 Fix RIF issue (sonic-net#835)

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants