Allow show ztp to display non-sensitive information visible to non-root user #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot user Signed-off-by: Rajendra Dendukuri <rajendra.dendukuri@broadcom.com>
lguohan
approved these changes
Apr 29, 2020
abdosi
pushed a commit
to abdosi/sonic-utilities
that referenced
this pull request
Aug 4, 2020
…ot user (sonic-net#872) Removed user privileges checks. These changes fix sonic-net#800. The ZTP PR sonic-net/sonic-ztp#13 is also required for these changes to work as expected. ``` admin@sonic:~$ show ztp status ZTP Admin Mode : True ZTP Service : Processing ZTP Status : IN-PROGRESS ZTP Source : local-fs (/host/ztp/ztp_data_local.json) Runtime : 06m 26s Timestamp : 2020-04-08 13:08:22 UTC ZTP Service is active 01-test-plugin: IN-PROGRESS ``` Signed-off-by: Rajendra Dendukuri <rajendra.dendukuri@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow show ztp to display non-sensitive information visible to non-root user
Signed-off-by: Rajendra Dendukuri rajendra.dendukuri@broadcom.com
- What I did
Removed user privileges checks. These changes fix #800. The ZTP PR sonic-net/sonic-ztp#13 is also required for these changes to work as expected.
- How I did it
Removed root user check.
- How to verify it
show ztp status
- Previous command output (if the output of a command-line utility has changed)
admin@sonic:~$ show ztp status
Root privileges are required for this operation
- New command output (if the output of a command-line utility has changed)
admin@sonic:~$ show ztp status
ZTP Admin Mode : True
ZTP Service : Processing
ZTP Status : IN-PROGRESS
ZTP Source : local-fs (/host/ztp/ztp_data_local.json)
Runtime : 06m 26s
Timestamp : 2020-04-08 13:08:22 UTC
ZTP Service is active
01-test-plugin: IN-PROGRESS