Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[utility] Filter FDB entries #890

Merged
merged 7 commits into from
Apr 28, 2020

Conversation

tahmed-dev
Copy link
Contributor

- What I did
FDB table can get large due to VM creation/deletion which cause
fast reboot to slow down. This utility fitlers FDB entries based on
current MAC entries in the ARP table.

signed-off-by: Tamer Ahmed tamer.ahmed@microsoft.com

- How I did it
code change

- How to verify it
run unit test
sudo pytest sonic-utilities-tests/filter_fdb_entries_test.py

- Previous command output (if the output of a command-line utility has changed)
N/A
- New command output (if the output of a command-line utility has changed)
N/A

@tahmed-dev tahmed-dev requested review from lguohan and yxieca April 24, 2020 21:33
FDB table can get large due to VM creation/deletion which cause
fast reboot to slow down. This utility fitlers FDB entries based on
current MAC entries in the ARP table.

signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
:
@tahmed-dev tahmed-dev force-pushed the taahme/filter-fdb-entries branch from c5c334e to 31e1c2e Compare April 24, 2020 21:36
@lgtm-com
Copy link

lgtm-com bot commented Apr 24, 2020

This pull request introduces 1 alert when merging 31e1c2e into fc719ad - view on LGTM.com

new alerts:

  • 1 for Unused import

@tahmed-dev tahmed-dev force-pushed the taahme/filter-fdb-entries branch from ca78249 to eebd32e Compare April 24, 2020 21:48
@tahmed-dev tahmed-dev marked this pull request as ready for review April 24, 2020 21:48
@lgtm-com
Copy link

lgtm-com bot commented Apr 24, 2020

This pull request introduces 1 alert when merging eebd32e into fc719ad - view on LGTM.com

new alerts:

  • 1 for Unused import

@tahmed-dev tahmed-dev requested a review from yxieca April 27, 2020 16:56
@yxieca
Copy link
Contributor

yxieca commented Apr 27, 2020

Where is the invocation of the script?

Copy link
Contributor Author

@tahmed-dev tahmed-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the invocation of the script?

added fast-reboot script to the PR

scripts/filter_fdb_entries.py Outdated Show resolved Hide resolved
scripts/filter_fdb_entries.py Outdated Show resolved Hide resolved
scripts/filter_fdb_entries.py Show resolved Hide resolved
yxieca
yxieca previously approved these changes Apr 27, 2020
@tahmed-dev tahmed-dev force-pushed the taahme/filter-fdb-entries branch from b2f8582 to f27f7ca Compare April 28, 2020 01:17
@tahmed-dev tahmed-dev merged commit 7ce5b62 into sonic-net:master Apr 28, 2020
@tahmed-dev tahmed-dev deleted the taahme/filter-fdb-entries branch April 28, 2020 03:48
yxieca pushed a commit that referenced this pull request Apr 28, 2020
* [utility] Filter FDB entries

FDB table can get large due to VM creation/deletion which cause
fast reboot to slow down. This utility fitlers FDB entries based on
current MAC entries in the ARP table.

signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
abdosi pushed a commit that referenced this pull request May 1, 2020
* [utility] Filter FDB entries

FDB table can get large due to VM creation/deletion which cause
fast reboot to slow down. This utility fitlers FDB entries based on
current MAC entries in the ARP table.

signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
abdosi pushed a commit to abdosi/sonic-utilities that referenced this pull request Aug 4, 2020
* [utility] Filter FDB entries

FDB table can get large due to VM creation/deletion which cause
fast reboot to slow down. This utility fitlers FDB entries based on
current MAC entries in the ARP table.

signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
CharlieChenEC pushed a commit to CharlieChenEC/sonic-utilities that referenced this pull request May 14, 2021
…ll be empty during fast-reboot process

    In PR: sonic-net#890
    > It adds an mechansim to filter out some entries to reduce the size of fdb.json.
      But it has a code defect which causes all fdb entries will be filtered out in some cases.

    Merge PR: sonic-net#1059 to fix the above issue.
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
[fwutil]: Fix firmware update command. (sonic-net#895)
[utility] Filter FDB entries (sonic-net#890)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants