Support load_minigraph command for multi NPU platform #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
lguohan
reviewed
May 6, 2020
config/main.py
Outdated
| run_command('{} pfcwd start_default'.format(ns_cmd_prefix), display_cmd=True) | ||
| if os.path.isfile('/etc/sonic/acl.json'): | ||
| run_command("acl-loader update full /etc/sonic/acl.json", display_cmd=True) | ||
| run_command("{} config qos reload".format(ns_cmd_prefix), display_cmd=True) |
There was a problem hiding this comment.
687-691 do not apply to default namespace in multi-asic environment.
There was a problem hiding this comment.
Fixed in the latest commit
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
lguohan
approved these changes
May 7, 2020
jleveque
approved these changes
May 7, 2020
|
@arlakshm, there's conflict cherry-picking. please raise a separate PR for 201911 branch. |
abdosi
pushed a commit
that referenced
this pull request
May 10, 2020
- Modify the load_minigraph command handler to support multi NPU platforms
abdosi
pushed a commit
to abdosi/sonic-utilities
that referenced
this pull request
Aug 4, 2020
…-net#896) - Modify the load_minigraph command handler to support multi NPU platforms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan arlakshm@microsoft.com
- What I did
Modify the load_minigraph command handler to support multi NPU platforms
This PR needs the changes from#4222 for the minigraph parsing changes
- How I did it
- How to verify it
- Previous command output (if the output of a command-line utility has changed)
No command output is changed
- New command output (if the output of a command-line utility has changed)
No command output is changed