Luxtorpeda: Update default LUXTORPEDACMD path
#1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonic2kk
changed the title
LUXTORPEDACMD path
|
Roberta still uses the same path, I downloaded it with ProtonUp-Qt and confirmed it still uses This PR needs a rebase and a version bump, and it is good to be merged. |
sonic2kk
force-pushed
the
update-default-luxtorpeda-path
branch
from
ce942d7
to
80a1921
Compare
|
I have an update to the wiki page ready to publish after this is merged. This is ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came up in #1177.
Related: #1178.
Luxtorpeda now uses a different launch command;
luxtorpeda.shinstead ofluxtorpeda. This PR updates the default path so that it uses this newer one.This won't retroactively affect global configs, it will only affect newly-created global configs. Not all users may be using a newer Luxtorpeda version that uses this newer entry point, but I think it makes sense for our default value to be what upstream uses as the default. If the path doesn't exist, then it won't show up in the Global Menu Yad box for it, and the user can surmise that the executable was not found and set the path themselves from here or in
global.confmanually (similar to what I described for the invalid path in #1178).TODO: