Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EOS-25963: User Defined IAM user Credentials Bug fix #2

Open
wants to merge 3 commits into
base: EOS-25963_IAMUSER_ext_ak_sk
Choose a base branch
from
Open

EOS-25963: User Defined IAM user Credentials Bug fix #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d308bf4
EOS-25963: Bug fix
Dec 27, 2021
b3256c0
EOS-25963: UT failure Fix
Dec 27, 2021
c8970ab
EOS-25963: clang formatting
Dec 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions auth/server/src/main/java/com/seagates3/parameter/validator/AccessKeyParameterValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,10 @@ public class AccessKeyParameterValidator extends AbstractParameterValidator {
@Override
public Boolean isValidCreateParams(Map<String, String> requestBody) {
boolean isValid = true;
if (requestBody.containsKey("UserName")) {
isValid =
S3ParameterValidatorUtil.isValidName(requestBody.get("UserName"));
} else {
isValid = false;
}

if (requestBody.containsKey("UserName")) {
isValid =
S3ParameterValidatorUtil.isValidName(requestBody.get("UserName"));
}
if (isValid) {
isValid = isAccessKeySecretKeyCombinationValid(
requestBody.get("AccessKey"), requestBody.get("SecretKey"));
Expand Down
2 changes: 1 addition & 1 deletion ...rver/src/test/java/com/seagates3/parameter/validator/AccessKeyParameterValidatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public void setUp() {
*/
@Test
public void Create_UserNameNull_True() {
assertFalse(accessKeyValidator.isValidCreateParams(requestBody));
assertTrue(accessKeyValidator.isValidCreateParams(requestBody));
}

/**
Expand Down