Task/fr new spec dt

[JohannaSimoens]

Improve coverage for French (new datetime subtypes)

Split file rules.rs in separate files per entity type (like in En)
Add moment and values utils to improve grammar (helpers)
Fixes related to subtypes date time (les n prochains mois/jours)

Add support for:

• quantifier 'quelques'
• de 'maintenant' à time-of-day (interval) , de time-of-day à 'maintenant' (interval)
• time-of-day (pile| exactement|précise)
• 'en ce moment'
• au (prochain|dernier) date
• 'saint-sylvestre'
• cycle 'trimestre'
• (beginning|middle|end) of season
• middle of the night
• sunrise, sunset
• from <meal|part-of-day|time-of-day> to <meal|part-of-day|time-of-day>
• depuis +
• prep + datetime enlarged
• (end|beginning) of this year
• approximation: vers time-of-day

Improve coverage test metric

Coverage test success rate: Before 59% -> Now 75%
(Taking into account failed case that are false negatives (real ambiguity cases like "demain à 5h" -> 5h | 17h, or interpretation of ranges for parts of day that need to be set : Before 65% -> Now 81%)

NB: Branch derived from branch 'task/datime-fr-new-specs' which is itself derived from branch 'feature/datetime_­subtypes' + is rebased onto 'task/split-grammar-files-entities-fr' (branch derived from develop (release 19.0) with rules files split per entity)

[adrienball]

Is there anything blocking here?

[adrienball]

OK got it, I guess that's fine then. Le mar. 30 juil. 2019 à 5:28 PM, Rosa Stern <notifications@github.com> a écrit :

***@***.**** commented on this pull request. ------------------------------ In grammar/fr/src/rules_amount.rs <#191 (comment)> : > @@ -0,0 +1,243 @@ +use rustling::*; +use rustling_ontology_values::dimension::*; +use rustling_ontology_values::dimension::Precision::*; +use rustling_ontology_values::helpers; + +pub fn rules_percentage(b: &mut RuleSetBuilder<Dimension>) -> RustlingResult<()> { + b.rule_2("<number> per cent", + number_check!(), + b.reg(r"(?:%|p\.c\.|p. cents?|pour[ -]?cents?)")?, + |number, _| Ok(PercentageValue(number.value().value())) + ); + Ok(()) +} Actually the "amount" rules and file were meant to group together amount entities, i.e. money amounts, temperatures and percentages. Do you want to have 3 separate files for each instead? — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#191>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACUE3W34Q3AC5N5BNJLKCB3QCBMZHANCNFSM4IH2WDCQ> .

-- *Adrien Ball* Data Scientist adrien.ball@snips.ai <rand.hindi@snips.ai> +33 6 70 87 57 78 Twitter: @adrien_ball Skype: adrien.ball