Skip to content

Commit

Permalink
WAR: temporarily disable partial repaints (#388)
Browse files Browse the repository at this point in the history
This change disables the partial repaints temporarily because of the flicker issue.
Once the root cause in flutter/engine was fixed and its change propagated to
the stable channel, this will be lifted up.

See #334 for the details.

Signed-off-by: Hidenori Matsubayashi <Hidenori.Matsubayashi@gmail.com>
  • Loading branch information
HidenoriMatsubayashi authored Sep 29, 2023
1 parent ac2a2c6 commit 820ee19
Showing 1 changed file with 6 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,11 @@ void ELinuxEGLSurface::PopulateExistingDamage(const intptr_t fbo_id,
0, 0, static_cast<double>(width_px_), static_cast<double>(height_px_)};
existing_damage->damage = existing_damage_map_[fbo_id];

// Temporarily disabled partial repaints due to
// https://github.com/sony/flutter-embedded-linux/issues/334. Once
// https://github.com/flutter/engine/pull/45611 was merged and propagated to
// the stable channel, this will be lifted up.
#if 0
if (age > 1) {
--age;
// join up to (age - 1) last rects from damage history
Expand All @@ -191,6 +196,7 @@ void ELinuxEGLSurface::PopulateExistingDamage(const intptr_t fbo_id,
}
}
}
#endif
}

// Auxiliary function used to transform a FlutterRect into the format that is
Expand Down

0 comments on commit 820ee19

Please sign in to comment.