Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: fix syntax error in event_channel.h #372

Merged

Conversation

HidenoriMatsubayashi
Copy link
Contributor

@HidenoriMatsubayashi HidenoriMatsubayashi commented Aug 17, 2023

This change fixes the following build error in event_channel.h.

/home/hidenori/work/flutter/flutter-elinux-plugins/packages/camera/example/elinux/flutter/ephemeral/cpp_client_wrapper/include/flutter/e vent_channel.h:95:27: error: invalid operands to binary expression ('basic_ostream<char, std::char_traits<char>>' and 'const std::unique_ptr<EncodableValue>')
                          << (error->error_details);
                          ^  ~~~~~~~~~~~~~~~~~~~~~~
/home/hidenori/work/flutter/flutter-elinux-plugins/packages/camera/example/elinux/flutter/ephemeral/.plugin_symlinks/camera_elinux/elinu x/channels/event_channel_image_stream.cc:44:18: note: in instantiation of member function 'flutter::EventChannel<>::SetStreamHandler' requested here
  event_channel->SetStreamHandler(std::move(event_channel_handler));
                 ^
/usr/bin/../lib/gcc/aarch64-linux-gnu/11/../../../../include/c++/11/system_error:279:5: note: candidate function template not viable: no known conversion from 'const std::unique_ptr<EncodableValue>' to 'const std::error_code' for 2nd argument
    operator<<(basic_ostream<_CharT, _Traits>& __os, const error_code& __e)
    ^
/usr/bin/../lib/gcc/aarch64-linux-gnu/11/../../../../include/c++/11/ostream:518:5: note: candidate function template not viable: no known conversion from 'const std::unique_ptr<EncodableValue>' to 'char' for 2nd argument
    operator<<(basic_ostream<_CharT, _Traits>& __out, char __c)

This change fixes the following build error in event_channel.h.

-----
/home/hidenori/work/flutter/flutter-elinux-plugins/packages/camera/example/elinux/flutter/ephemeral/cpp_client_wrapper/include/flutter/e
vent_channel.h:95:27: error: invalid operands to binary expression ('basic_ostream<char, std::char_traits<char>>' and 'const
std::unique_ptr<EncodableValue>')
                          << (error->error_details);
                          ^  ~~~~~~~~~~~~~~~~~~~~~~
/home/hidenori/work/flutter/flutter-elinux-plugins/packages/camera/example/elinux/flutter/ephemeral/.plugin_symlinks/camera_elinux/elinu
x/channels/event_channel_image_stream.cc:44:18: note: in instantiation of member function 'flutter::EventChannel<>::SetStreamHandler'
requested here
  event_channel->SetStreamHandler(std::move(event_channel_handler));
                 ^
/usr/bin/../lib/gcc/aarch64-linux-gnu/11/../../../../include/c++/11/system_error:279:5: note: candidate function template not viable: no
known conversion from 'const std::unique_ptr<EncodableValue>' to 'const std::error_code' for 2nd argument
    operator<<(basic_ostream<_CharT, _Traits>& __os, const error_code& __e)
    ^
/usr/bin/../lib/gcc/aarch64-linux-gnu/11/../../../../include/c++/11/ostream:518:5: note: candidate function template not viable: no
known conversion from 'const std::unique_ptr<EncodableValue>' to 'char' for 2nd argument
    operator<<(basic_ostream<_CharT, _Traits>& __out, char __c)
-----

Signed-off-by: Hidenori Matsubayashi <Hidenori.Matsubayashi@gmail.com>
@HidenoriMatsubayashi HidenoriMatsubayashi added bug Something isn't working engine Topics of Flutter Engine and its artifacts labels Aug 17, 2023
@HidenoriMatsubayashi
Copy link
Contributor Author

HidenoriMatsubayashi commented Aug 17, 2023

See also flutter/flutter#101682 (comment)

@HidenoriMatsubayashi HidenoriMatsubayashi merged commit 23589c3 into sony:master Aug 17, 2023
1 check passed
@HidenoriMatsubayashi HidenoriMatsubayashi deleted the fix-event-channel branch August 17, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working engine Topics of Flutter Engine and its artifacts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant