Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

egl_stream: add cast to EGLAttrib #400

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

makotosato-at
Copy link
Contributor

Hello.

I'm trying to build for armhf.
In the process, I met the following errors.

context_egl_stream.cc:31:26: error: non-constant-expression cannot be narrowed from type 'uint32_t' (aka 'unsigned int') to 'EGLAttrib' (aka 'int') in initializer list [-Wc++11-narrowing]
      EGL_DRM_PLANE_EXT, static_cast<NativeWindowDrmEglstream*>(window)->PlaneId(),
                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
context_egl_stream.cc:31:26: note: insert an explicit cast to silence this issue
      EGL_DRM_PLANE_EXT, static_cast<NativeWindowDrmEglstream*>(window)->PlaneId(),
                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                         static_cast<EGLAttrib>(                                  )
1 error generated.

So I added a cast.

Signed-off-by: Makoto Sato <makoto.sato@atmark-techno.com>
Copy link
Contributor

@HidenoriMatsubayashi HidenoriMatsubayashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@HidenoriMatsubayashi HidenoriMatsubayashi merged commit bd5e4b6 into sony:master Nov 9, 2023
1 check passed
@HidenoriMatsubayashi HidenoriMatsubayashi added bug Something isn't working drm Topics of DRM backend arm-32bit Topics of ARM 32bit support labels Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arm-32bit Topics of ARM 32bit support bug Something isn't working drm Topics of DRM backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants