Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ubuntu 20.04 test runner installation of SDPoker #218

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

garethsb
Copy link
Contributor

@garethsb garethsb commented Dec 7, 2021

Explicitly specify git+https://git@github.com/{user}/{repo}.git to workaround npm "feature" of rewriting GitHub package specs (npm/cli#2610), which applies on GitHub Actions after the Ubuntu 20.04 image 20211129.1 update (actions/runner-images#4625) upgraded to Node v16.13.0 (npm v8.1.0)

Finally, stop using sudo in order to avoid permissions issue on the npm cache (npm/cli#624)

Explicitly pecify git+https://git@github.com/{user}/{repo}.git to workaround npm "feature" of rewriting GitHub package specs (npm/cli#2610), which applies on GitHub Actions after the Ubuntu 20.04 image 20211129.1 update (actions/runner-images#4625) upgraded to Node v16.13.0 (npm v8.1.0)

Finally, stop using sudo in order to avoid permissions issue on the npm cache (npm/cli#624)
@jonathan-r-thorpe jonathan-r-thorpe merged commit 5144d9f into sony:master Dec 7, 2021
@garethsb garethsb deleted the npm-ubuntu-20.04 branch April 22, 2022 07:45
garethsb added a commit to garethsb/nmos-cpp that referenced this pull request Apr 28, 2022
* for build and dependencies, e.g. sony#197, sony#198, sony#207, sony#211, sony#215, sony#229, sony#230, sony#235, sony#243
* for SDP parser/generator, e.g. sony#201, sony#205, sony#219, sony#241, sony#242, sony#244
* for RQL, e.g. sony#224
* for CI tests, e.g. sony#218, sony#231, sony#239, sony#250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants