Add new interface and method for sending command #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sending command job is giving up if command cannot be sent with any reason. It means that command would be lost if gerrit is down. This patch adds new interface then implement it to abstract class to raise exception if command was not sent with errors. User can implement retry logic using this.
rsandell
added a commit
that referenced
this pull request
Aug 26, 2014
Add new interface and method for sending command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending command job is giving up if command cannot be sent with any
reason. It means that command would be lost if gerrit is down.
This patch adds new interface then implement it to abstract class
to raise exception if command was not sent with errors.
User can implement retry logic using this.