Add abstract classes for command job based on Callable #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds 2 abstract classes for command job. Those implement Callable. So user can get command response asynchronously using Future object. It has possibility to have something issue if both Runnable and Callable are implemented into one class. So implemented as new class. In addition: * Replace some deprecated API for HttpClient to modern API. * Add new command job support to GerritSendCommandQueue.
rsandell
added a commit
that referenced
this pull request
Sep 22, 2014
Add abstract classes for command job based on Callable
|
Just say when you need the merged changes and I'll make a new release. |
|
I would ask to you when time comes. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds 2 abstract classes for command job.
Those implement Callable. So user can get command response
asynchronously using Future object.
It has possibility to have something issue if both Runnable
and Callable are implemented into one class. So implemented
as new class.
In addition: