Fix [JENKINS-12690] root cause, by upgrading j2ssh to j2ssh-maverick … #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for AES key encryption Passphrase validation would fail for modern keys created with AES-128-CBC key encryption (now default) j2ssh library does not support this algorithm (hard-coded, so it can't be added by adding an SPI) To support this, j2ssh dependency has been replaced with j2ssh-maverick library (its successor, latest version) An appropriate test has been added, and calls to j2ssh have been adjusted appropriately
rsandell
added a commit
that referenced
this pull request
Sep 14, 2015
Fix [JENKINS-12690] root cause, by upgrading j2ssh to j2ssh-maverick …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…for AES key encryption
Passphrase validation would fail for modern keys created with AES-128-CBC key encryption (now default)
j2ssh library does not support this algorithm (hard-coded, so it can't be added by adding an SPI)
To support this, j2ssh dependency has been replaced with j2ssh-maverick library (its successor, latest version)
An appropriate test has been added, and calls to j2ssh have been adjusted appropriately