Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the time consume problem in method instructionAtAddress #2060

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

wangnianwu
Copy link

If the address is not continuous, it will visit all integers from the current to target address(The length exceeds the map size), it causes taking too much time to call retrieveActiveBody in SootMethod.

@jpstotz
Copy link
Contributor

jpstotz commented Mar 26, 2024

As you have changed the Map type from HashMap to TreeMap wouldn't it be easier to use the TreeMap specific functions like floorKey or ceilingKey to get the nearest instruction to an address instead of iterating through the whole TreeMap to find the address?

@wangnianwu
Copy link
Author

@jpstotz updated it by your advise

@StevenArzt StevenArzt merged commit e0f38c7 into soot-oss:develop Mar 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants