Skip to content

Commit

Permalink
Rollup merge of rust-lang#35353 - poveda-ruiz:master, r=jonathandturner
Browse files Browse the repository at this point in the history
Updated E0081 to new format

Part of rust-lang#35233. r? @jonathandturner
  • Loading branch information
Jonathan Turner committed Aug 5, 2016
2 parents 843a3e9 + 00179a7 commit c3c287c
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 8 deletions.
5 changes: 3 additions & 2 deletions src/librustc_typeck/check/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1251,8 +1251,9 @@ pub fn check_enum_variants<'a,'tcx>(ccx: &CrateCtxt<'a,'tcx>,
let mut err = struct_span_err!(ccx.tcx.sess, v.span, E0081,
"discriminant value `{}` already exists", disr_vals[i]);
let variant_i_node_id = ccx.tcx.map.as_local_node_id(variants[i].did).unwrap();
span_note!(&mut err, ccx.tcx.map.span(variant_i_node_id),
"conflicting discriminant here");
err.span_label(ccx.tcx.map.span(variant_i_node_id),
&format!("first use of `{}`", disr_vals[i]));
err.span_label(v.span , &format!("enum already has `{}`", disr_vals[i]));
err.emit();
}
disr_vals.push(current_disr_val);
Expand Down
17 changes: 11 additions & 6 deletions src/test/compile-fail/issue-15524.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,18 @@ const N: isize = 1;

enum Foo {
A = 1,
B = 1, //~ ERROR discriminant value `1isize` already exists
//~^^ NOTE conflicting
//~^ NOTE first use
//~| NOTE first use
//~| NOTE first use
B = 1, //~ ERROR discriminant value
//~^ NOTE enum already
C = 0,
D, //~ ERROR discriminant value `1isize` already exists
//~^^^^^ NOTE conflicting
E = N, //~ ERROR discriminant value `1isize` already exists
//~^^^^^^^ NOTE conflicting
D, //~ ERROR discriminant value
//~^ NOTE enum already

E = N, //~ ERROR discriminant value
//~^ NOTE enum already

}

fn main() {}

0 comments on commit c3c287c

Please sign in to comment.