Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] 이메일 인증 버튼 크기 깨지는 에러 해결 #353

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

eonseok-jeon
Copy link
Member

@eonseok-jeon eonseok-jeon commented Aug 6, 2024

Related Issue : Closes #349


🧑‍🎤 Summary

  • window + chrome 환경에서 이메일 인증 버튼 디자인 깨지는 에러 해결

🧑‍🎤 Comment

window가 없어서 테스트는 못 해봤어요
하지만 건영님이 테스트 해본 방식을 적용했기에 잘 작동할 것으로 판단이 됩니다

이메일 확인버튼과 인증 확인 버튼은 공통 컴포넌트를 공유하고 있는데
인증 확인 버튼의 크기가 이메일 확인 버튼의 크기와 일치해야 했어요
그렇기에 width를 고정적으로 박아야 해서 width: max-content는 이용할 수가 없었어요

대신 두 번째 추천 방법인 padding을 줄이는 방법을 택했습니다

사파리와 크롬, arc, firefox에서 문제 없는 거 확인했습니다!

@eonseok-jeon eonseok-jeon linked an issue Aug 6, 2024 that may be closed by this pull request
Copy link

height bot commented Aug 6, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link
Member

@lydiacho lydiacho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠른 작업 감사합니다!!! 🚀

@eonseok-jeon eonseok-jeon merged commit 2901080 into develop Aug 6, 2024
1 check passed
@eonseok-jeon eonseok-jeon deleted the fix/#349_email-button branch August 6, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fix] 이메일 인증 버튼 크기 깨지는 에러 해결
2 participants