Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add Linting Workflow for GHA Workflows #31

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

kevinmatthes
Copy link
Contributor

This PR adds a new GitHub Action workflow which will run a lightweight linter on all GitHub Action workflow files whenever they were edited. This shall make sure that syntactical issues can be identified rather quickly without having to search for them manually. The workflow will determine the validity of both the workflow files and the shell scripts they contain in about 5 seconds by pulling a Docker image of the linter "actionlint".

@kevinmatthes kevinmatthes marked this pull request as draft June 12, 2023 17:39
@kevinmatthes kevinmatthes marked this pull request as ready for review June 12, 2023 17:42
@kevinmatthes
Copy link
Contributor Author

I also added the PR trigger to both the actionlint and the cffconvert workflows to catch errors in the tracked files before they are introduced to the code base.

@sorairolake sorairolake merged commit aa57a4c into sorairolake:develop Jun 13, 2023
@sorairolake
Copy link
Owner

@kevinmatthes Thanks!

@kevinmatthes kevinmatthes deleted the feature/actionlint branch June 13, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants