Skip to content

Commit

Permalink
Refresh dependencies, drop node-sass
Browse files Browse the repository at this point in the history
`npm audit` revealed some vulnerabilities:

```

scss-tokenizer  <=0.4.2
Severity: high
Regular expression denial of service in scss-tokenizer - GHSA-7mwh-4pqv-wmr8
fix available via `npm audit fix --force`
Will install node-sass@4.5.3, which is a breaking change
node_modules/scss-tokenizer
  sass-graph  >=2.2.0
  Depends on vulnerable versions of scss-tokenizer
  node_modules/sass-graph
    node-sass  >=4.6.0
    Depends on vulnerable versions of sass-graph
    node_modules/node-sass

3 high severity vulnerabilities

```

We don't need node-sass, and sass-loader is just as happy using
another sass implementation. The preferred one is dart-sass which
is simply called sass in npm.

In the process, I also did an `npm update` just for good measure.
  • Loading branch information
sorenisanerd committed Aug 27, 2022
1 parent d0e3ffb commit 94e5873
Show file tree
Hide file tree
Showing 8 changed files with 1,014 additions and 4,177 deletions.
18 changes: 14 additions & 4 deletions bindata/static/css/xterm.css
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
*/

.xterm {
cursor: text;
position: relative;
user-select: none;
-ms-user-select: none;
Expand Down Expand Up @@ -124,10 +125,6 @@
line-height: normal;
}

.xterm {
cursor: text;
}

.xterm.enable-mouse-events {
/* When mouse events are enabled (eg. tmux), revert to the standard pointer cursor */
cursor: default;
Expand Down Expand Up @@ -178,3 +175,16 @@
z-index: 6;
position: absolute;
}

.xterm-decoration-overview-ruler {
z-index: 7;
position: absolute;
top: 0;
right: 0;
pointer-events: none;
}

.xterm-decoration-top {
z-index: 2;
position: relative;
}
2 changes: 1 addition & 1 deletion bindata/static/js/gotty.js

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions bindata/static/js/gotty.js.LICENSE.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*!
* Bootstrap v5.1.3 (https://getbootstrap.com/)
* Copyright 2011-2021 The Bootstrap Authors (https://github.com/twbs/bootstrap/graphs/contributors)
* Bootstrap v5.2.0 (https://getbootstrap.com/)
* Copyright 2011-2022 The Bootstrap Authors (https://github.com/twbs/bootstrap/graphs/contributors)
* Licensed under MIT (https://github.com/twbs/bootstrap/blob/main/LICENSE)
*/

Expand Down
2 changes: 1 addition & 1 deletion bindata/static/js/gotty.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions bindata/static/js/gotty.licenses.txt
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ bootstrap
MIT
The MIT License (MIT)

Copyright (c) 2011-2021 Twitter, Inc.
Copyright (c) 2011-2021 The Bootstrap Authors
Copyright (c) 2011-2022 Twitter, Inc.
Copyright (c) 2011-2022 The Bootstrap Authors

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down
5,148 changes: 989 additions & 4,159 deletions js/package-lock.json

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"license-loader": "^0.5.0",
"license-webpack-plugin": "^4.0.2",
"purgecss": "^4.1.3",
"sass": "^1.50.0",
"sass": "^1.54.5",
"sass-loader": "^12.6.0",
"terser-webpack-plugin": "^5.3.1",
"ts-loader": "^8.3.0",
Expand All @@ -21,7 +21,6 @@
"bootstrap": "^5.1.3",
"css-loader": "^5.2.6",
"debounce": "^1.2.1",
"node-sass": "^7.0.1",
"preact": "^10.7.1",
"react-bootstrap": "^2.2.3",
"style-loader": "^2.0.0",
Expand Down
10 changes: 4 additions & 6 deletions js/src/bootstrap.scss
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
/*!
* Bootstrap v5.1.3 (https://getbootstrap.com/)
* Copyright 2011-2021 The Bootstrap Authors
* Copyright 2011-2021 Twitter, Inc.
* Licensed under MIT (https://github.com/twbs/bootstrap/blob/main/LICENSE)
*/
@import "mixins/banner";
@include bsBanner("");


// scss-docs-start import-stack
// Configuration
@import "functions";
@import "variables";
@import "maps";
@import "mixins";
@import "utilities";

Expand Down

0 comments on commit 94e5873

Please sign in to comment.