Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow enhanced author parsing #1406

Merged
merged 4 commits into from
Mar 25, 2023
Merged

Allow enhanced author parsing #1406

merged 4 commits into from
Mar 25, 2023

Conversation

pagreene
Copy link
Contributor

This is a small PR that adds the option to get full details given about an author in PubMed XMLs. The default behavior remains the same, however there is a new keyword argument in the get_metadata_from_xml_tree function called detailed_authors that can be set to True to get this behavior.

@pagreene pagreene requested a review from bgyori March 25, 2023 19:41
bgyori
bgyori approved these changes Mar 25, 2023
View reviewed changes
Copy link
Member

@bgyori bgyori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pagreene, this is a good addition! I added this option to one of the higher level functions and extended an existing test to check the content with/without the new flag.

@bgyori bgyori merged commit b358526 into sorgerlab:master Mar 25, 2023
@pagreene pagreene deleted the enhance-author-parsing branch March 27, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgyori bgyori bgyori approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pagreene @bgyori