Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get article references, either just PMIDs or details #1407

Merged
merged 3 commits into from
May 2, 2023
Merged

Get article references, either just PMIDs or details #1407

merged 3 commits into from
May 2, 2023

Conversation

pagreene
Copy link
Contributor

This is another small PR that:

  1. Fixes a bug introduced in my last PR (sorry) where you sometimes get an error if an author's last name isn't given, and you chose the default name-only option for getting authors
  2. Adds the ability to include references with the article data, with 3 options: None (no references), 'pmid' (just the pmids), or 'detailed' (getting everything available, more or less). The default is None, which maintains the status quo.

I also added a test for the new functionality.

@pagreene pagreene requested a review from bgyori April 18, 2023 04:10
bgyori
bgyori approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@bgyori bgyori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pagreene, this looks good!

@bgyori bgyori merged commit d6b7240 into sorgerlab:master May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgyori bgyori bgyori approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pagreene @bgyori