Remove mesh cycle from bio-ontology #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All the failing tests are related to 404 errors from the cbio client |
bgyori
reviewed
Jan 14, 2024
| continue | ||
|
|
||
| # Remove the edge | ||
| self.remove_edge(source, target) |
There was a problem hiding this comment.
It is unlikely to play a big role here but removing edges one by one tends to be slower than using remove_edges_from with a list argument. We can leave it like this for simplicity though.
bgyori
force-pushed
the
remove-mesh-cycle
branch
from
aec1b47
to
61f7ce2
Compare
bgyori
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to remove edges from the bio ontology and does that for one edge in the MeSH 2024 data. The edge removed is
MESH:D015835 -[isa]-> MESH:D013285which prevents a circular hierarchy structure sinceMESH:D013285 -[isa]-> MESH:D015835is already a relation. See https://meshb.nlm.nih.gov/record/ui?ui=D015835 under the MeSH Tree Structure tab then check the branch forNervous System Diseases [C10]where the hierarchical pathMESH:D015835 -> MESH:D013285 -> MESH:D015835is present, creating anis_a/partofcycle.The bio ontology version is bumped to 1.32 with this PR.