Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add styled components #2

Closed
wants to merge 3 commits into from
Closed

Add styled components #2

wants to merge 3 commits into from

Conversation

Jonesus
Copy link
Contributor

@Jonesus Jonesus commented Nov 3, 2019

Adds support for Styled Components for more readable component structure

args: 'after-used',
argsIgnorePattern: '^_$',
ignoreRestSiblings: true,
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really related but 🔥 A U T O F O R M A T T I N G 🔥 updated these so thought why not

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my inline comment was not good : (. That inline commenting thing is kinda hard as it does not do formatting

@@ -14,7 +14,7 @@ module.exports = {
'react',
'react-hooks',
'react-native',
],
],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 A U T O F O R M A T T I N G 🔥

Comment on lines +26 to +29
parserOptions: {
project: './tsconfig.json',
tsconfigRootDir: __dirname,
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might've not been caused by the inclusion of styled-components but it was an error thrown by eslint so lemme fix

"name": "typescript-styled-plugin",
"validate": false,
"lint": {
"validProperties": [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should allow the following CSS properties to be used with styled-components, but it might not work properly with VSCode anyways:
microsoft/typescript-styled-plugin#58

Copy link
Contributor

@pheis pheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you do plain styles with styled? For example to pass a contentContainer prop to a scollView?

@Jonesus
Copy link
Contributor Author

Jonesus commented Nov 4, 2019

How do you do plain styles with styled? For example to pass a contentContainer prop to a scollView?

You mean contentContainerStyle? That's actually a good question I hadn't thought about, it seems that styled-components can't really help with that use case, but I'm not sure that it's a problem, then we can simply use the normal way of defining styles and pass them to the ScrollView as a prop

@rottabonus
Copy link
Member

Closing because this is from year 2019, nothing is happening anymore in this regard

@rottabonus rottabonus closed this May 14, 2023
@rottabonus rottabonus deleted the joonas/styled-components branch May 14, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants