Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NetworkManager keyfiles are not being gathered from all locations #3875

Closed
palonsoro opened this issue Dec 12, 2024 · 2 comments · Fixed by #3876
Closed

NetworkManager keyfiles are not being gathered from all locations #3875

palonsoro opened this issue Dec 12, 2024 · 2 comments · Fixed by #3876

Comments

@palonsoro
Copy link
Contributor

Currently, the networkmanager sos plugin collects all the NetworkManager connection keyfiles from /etc/NetworkManager/system-connections as we can see here.

However, that's not the only location for NetworkManager connection keyfiles. As we can see in man 5 nm-settings-keyfile, the apart from /etc/NetworkManager/system-connections/, we should be including /usr/lib/NetworkManager/system-connections/ and /run/NetworkManager/system-connections/.

The latter is specially important in case that temporary in-memory connections are defined, like the default auto-generated ones.
@jcastill
Copy link
Member

Thank you for opening the issue @palonsoro . I imagine that we have to mask passwords and secrets from these locations as well, since the file formats will be the same in all of them, right?

jcastill added a commit to jcastill/sos that referenced this issue Dec 12, 2024
@jcastill
[NetworkManager] Get system-connections files from other locations
00cdb60 
system-connections files can be found not only under
/etc/NetworkManager, but also /usr/lib/NetworkManager and
/run/NetworkManager, so we need to capture and post process
these locations as well.

Resolves: sosreport#3875

Signed-off-by: Jose Castillo <jcastillo@redhat.com>
@jcastill jcastill mentioned this issue Dec 12, 2024
Merged
6 tasks
@palonsoro
Copy link
Contributor Author

Thank you for opening the issue @palonsoro . I imagine that we have to mask passwords and secrets from these locations as well, since the file formats will be the same in all of them, right?

Correct. Same data masking must be done on those files too. It is the same format (in case you are curious, it is documented in man 5 nm-settings-keyfile and man 5 nm-settings).

jcastill added a commit to jcastill/sos that referenced this issue Dec 13, 2024
@jcastill
[NetworkManager] Get system-connections files from other locations
cd7ba2f 
system-connections files can be found not only under
/etc/NetworkManager, but also /usr/lib/NetworkManager and
/run/NetworkManager, so we need to capture and post process
these locations as well.

Resolves: sosreport#3875

Signed-off-by: Jose Castillo <jcastillo@redhat.com>
jcastill added a commit to jcastill/sos that referenced this issue Dec 13, 2024
@jcastill
[NetworkManager] Get system-connections files from other locations
26914e0 
system-connections files can be found not only under
/etc/NetworkManager, but also /usr/lib/NetworkManager and
/run/NetworkManager, so we need to capture and post process
these locations as well.

Resolves: sosreport#3875

Signed-off-by: Jose Castillo <jcastillo@redhat.com>
jcastill added a commit to jcastill/sos that referenced this issue Dec 13, 2024
@jcastill
[NetworkManager] Get system-connections files from other locations
2f39d3d 
system-connections files can be found not only under
/etc/NetworkManager, but also /usr/lib/NetworkManager and
/run/NetworkManager, so we need to capture and post process
these locations as well.

Resolves: sosreport#3875

Signed-off-by: Jose Castillo <jcastillo@redhat.com>
arif-ali pushed a commit that referenced this issue Dec 13, 2024
@jcastill @arif-ali
[NetworkManager] Get system-connections files from other locations
2bdf051 
system-connections files can be found not only under
/etc/NetworkManager, but also /usr/lib/NetworkManager and
/run/NetworkManager, so we need to capture and post process
these locations as well.

Resolves: #3875

Signed-off-by: Jose Castillo <jcastillo@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[NetworkManager] Get system-connections files from other locations jcastill/sos
2 participants
@palonsoro @jcastill