Add from_attitude class method for more permissive init #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taldcroft
force-pushed
the
from-attitude
branch
from
ca4dd3d to
deafcb0
Compare
2 tasks
16 tasks
javierggt
reviewed
Oct 25, 2021
Quaternion/Quaternion.py
Outdated
| Attitude(s) as a Quat | ||
| """ | ||
| if isinstance(att, Quat): | ||
| return att |
There was a problem hiding this comment.
In all the other cases below, this function returns a new object, while here it returns the same input object. Should we be consistent and return a copy always?
One way this can backfire is when the user creates quaternions within a loop, from a single quaternion instance. All "new" quaternions will actually be a pointer to the same one instance (which will have values from the last iteration).
| except Exception: | ||
| pass | ||
| else: | ||
| return att |
There was a problem hiding this comment.
This line was not covered in tests, according to coverage.py.
Quaternion/Quaternion.py
Outdated
| Attitude(s) as a Quat | ||
| """ | ||
| if isinstance(att, Quat): | ||
| return att |
There was a problem hiding this comment.
This line was not covered in tests, according to coverage.py.
|
Thanks, I think I addressed all comments. |
javierggt
approved these changes
Oct 25, 2021
This was referenced Oct 25, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows more permissive initialization of a Quaternion for cases when the input is known to be an attitude (instead of e.g. a 3x3 transform).
Testing