Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add available comms to timeline plot #87

Merged
merged 10 commits into from
Dec 7, 2024
Merged

Conversation

taldcroft
Copy link
Member

@taldcroft taldcroft commented Nov 15, 2024

Description

FOT MP maintains a table of "available comms", which means intervals when DSN stations are in view of Chandra and are not currently scheduled for another mission. This means they could likely be used by Chandra if needed.

This update to Replan Central uses that table of available comms to annotate the timeline plot accordingly. This will help with planning anomaly recovery efforts. This adds two new elements:

  • A grey timeline strip to the bottom of the timeline plot and the text annotation Avail comms to the bottom right.
  • A new table of available comms below the table of timeline status data. This table is hidden by default and can be toggled on/off with a button click.

Example output is at: https://cxc.cfa.harvard.edu/mta/ASPECT/tests/arc/pr87/arc3/

Interface impacts

The Replan Central HTML and timeline PNG are updated according to the description.

Functional testing

First followed instructions in the Wiki to create a testing environment on kadi and then the instructions below. This is done in the git repo at 071a552.

Output:

# Environment setup
export ska_dir=/export/tom/arc3_test
source ${ska_dir}/bin/activate
source ${ska_dir}/bin/ska_envs.sh

# Make sure the outputs are going to an expected directory
echo $SKA_DATA

# Install
make install

# Run through all jobs in task schedule
${SKA_SHARE}/arc3/get_iFOT_events.pl
${SKA_SHARE}/arc3/get_web_content.pl
${SKA_SHARE}/arc3/get_goes_x.py --h5=${SKA_DATA}/arc3/GOES_X.h5
${SKA_SHARE}/arc3/plot_goes_x.py --h5=${SKA_DATA}/arc3/GOES_X.h5 --out=${SKA}/www/ASPECT/arc3/goes_x.png
${SKA_SHARE}/arc3/get_ace.py --h5=${SKA_DATA}/arc3/ACE.h5
${SKA_SHARE}/arc3/get_hrc.py --h5=${SKA_DATA}/arc3/hrc_shield.h5 --data-dir=${SKA_DATA}/arc3
${SKA_SHARE}/arc3/plot_hrc.py --h5=${SKA_DATA}/arc3/hrc_shield.h5 --out=${SKA}/www/ASPECT/arc3/hrc_shield.png
${SKA_SHARE}/arc3/make_timeline.py --data-dir=${SKA_DATA}/arc3
${SKA_SHARE}/arc3/arc.pl
${SKA_SHARE}/arc3/arc.pl -config arc3:arc_ops
${SKA_SHARE}/arc3/arc_time_machine.pl

# Testing outputs for documentation
mkdir -p /proj/sot/ska/www/ASPECT/tests/arc/pr87/arc3

# Normal success
${SKA_SHARE}/arc3/make_timeline.py --data-dir=${SKA_DATA}/arc3
${SKA_SHARE}/arc3/arc.pl
rsync -av $SKA/www/ASPECT/arc3/ /proj/sot/ska/www/ASPECT/tests/arc/pr87/arc3/

# Failed read of available comms URL
env ARC_TEST_SCENARIO=avail-comms-read-fail ${SKA_SHARE}/arc3/make_timeline.py --data-dir=${SKA_DATA}/arc3
${SKA_SHARE}/arc3/arc.pl
rsync -av $SKA/www/ASPECT/arc3/ /proj/sot/ska/www/ASPECT/tests/arc/pr87/arc3/fail-read/

# Successful read but no available comms (zero-length table)
env ARC_TEST_SCENARIO=avail-comms-zero-len ${SKA_SHARE}/arc3/make_timeline.py --data-dir=${SKA_DATA}/arc3/
${SKA_SHARE}/arc3/arc.pl
rsync -av $SKA/www/ASPECT/arc3/ /proj/sot/ska/www/ASPECT/tests/arc/pr87/arc3/zero-len/

Base automatically changed from refactor-modernize to master November 29, 2024 19:08
@taldcroft taldcroft force-pushed the timeline-avail-comms branch from 6904ff3 to 6ca06dd Compare November 29, 2024 19:10
Copy link
Contributor

@jeanconn jeanconn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I also did a pass through updating the wiki test setup doc for what worked for me setting up and running it today.

@taldcroft taldcroft merged commit 81c4972 into master Dec 7, 2024
2 checks passed
@taldcroft taldcroft deleted the timeline-avail-comms branch December 7, 2024 11:13
@taldcroft
Copy link
Member Author

I decided to just go ahead and bring this straight to FSDS (https://occ-cfa.cfa.harvard.edu/browse/FSDS-143).

@jeanconn
Copy link
Contributor

jeanconn commented Dec 7, 2024

That's fine, though I would like to bump the version.

@taldcroft
Copy link
Member Author

Oops, forgot that is a thing...

@jeanconn
Copy link
Contributor

jeanconn commented Dec 7, 2024

Nothing actually uses it anyway ...

@jeanconn
Copy link
Contributor

jeanconn commented Dec 7, 2024

I just pushed the version 4.9.0 to master and made https://github.com/sot/arc/releases/tag/4.9.0 which could be the thing we install for the FSDS.

@taldcroft
Copy link
Member Author

Thanks @jeanconn !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants