Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add t_ccd_ref_alpha #173

Closed
wants to merge 1 commit into from
Closed

add t_ccd_ref_alpha #173

wants to merge 1 commit into from

Conversation

javierggt
Copy link
Contributor

@jeanconn

This is the change I propose in #172 (this can just be merged there).

@taldcroft
Copy link
Member

taldcroft commented Aug 31, 2024

@javierggt - See the functional testing of this in https://github.com/sot/acdc/pull/87.

The upshot is that varying t_ccd_ref_alpha by +/- 10 C makes the trending plots noticeably worse or unphysical.

Full disclosure is that I have not reviewed the details of the model derivation. That said, my understanding was that the best-fit parameters a, b, c, d, e would be dependent on t_ccd_ref_alpha. I think this assumption is validated with the functional testing which demonstrates that the current hardcoded a, b, c, d, e give optimal results only for t_ccd_ref_alpha=265.15. Any variations in that parameter without corresponding changes in the other parameters will degrade the dark current scaling model.

Is that correct?

Base automatically changed from new-scaling to master September 16, 2024 16:04
@javierggt javierggt closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants